Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing information on underscore usage to the book #34903

Closed
SplittyDev opened this issue Jul 18, 2016 · 6 comments
Closed

Add missing information on underscore usage to the book #34903

SplittyDev opened this issue Jul 18, 2016 · 6 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@SplittyDev
Copy link

I noticed that there is virtually no information on the usage of underscores in numeric literals in the book.

The syntax index only mentions underscores in the context of pattern matching as "ignored" pattern binding, so I suggest adding the other use of underscores to the syntax index too.
@steveklabnik steveklabnik added A-docs E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. E-help-wanted Call for participation: Help is requested to fix this issue. labels Jul 18, 2016
@steveklabnik
Copy link
Member

I would be willing to mentor anyone who wants to help with this issue.

@abhijeetbhagat
Copy link
Contributor

I can update.

@abhijeetbhagat
Copy link
Contributor

abhijeetbhagat commented Jul 22, 2016 •
edited
Loading

@SplittyDev btw there is text about using underscores in integer literals here and here

steveklabnik added a commit to steveklabnik/rust that referenced this issue Jul 25, 2016
@steveklabnik
Rollup merge of rust-lang#34990 - abhijeetbhagat:patch-3, r=steveklabnik
4d44503 
Update underscore usage (rust-lang#34903)
steveklabnik added a commit to steveklabnik/rust that referenced this issue Jul 26, 2016
@steveklabnik
Rollup merge of rust-lang#34990 - abhijeetbhagat:patch-3, r=steveklabnik
96108bb 
Update underscore usage (rust-lang#34903)
@kyrias
Copy link
Contributor

kyrias commented Aug 20, 2016

Is #34990 enough for this, or do you want something more in-depth?

@pmatos
Copy link
Contributor

pmatos commented Sep 28, 2016

It seems #34990 was merged, should this be closed?

@steveklabnik
Copy link
Member

I believe so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pmatos @steveklabnik @kyrias @SplittyDev @abhijeetbhagat