Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure --target=arm-unknown-linux-gnueabihf,arm-unknown-linux-gnueabi ignores the arm-unknown-linux-gnueabi target #32176

Closed
japaric opened this issue Mar 10, 2016 · 3 comments
Labels
C-bug Category: This is a bug.

Comments

@japaric
Copy link
Member

japaric commented Mar 10, 2016

STR

# This ignores the arm-unknown-linux-gnueabi target
$ git clone --depth 1 https://github.com/rust-lang/rust
$ rust/configure --target=arm-unknown-linux-gnueabihf,arm-unknown-linux-gnueabi
$ cat config.mk | grep CFG_TARGET
CFG_TARGET           := x86_64-unknown-linux-gnu arm-unknown-linux-gnueabihf

# But this (swapped targets) accepts both targets
$ rust/configure --target=arm-unknown-linux-gnueabi,arm-unknown-linux-gnueabihf
$ cat config.mk | grep CFG_TARGET
CFG_TARGET           := x86_64-unknown-linux-gnu arm-unknown-linux-gnueabi arm-unknown-linux-gnueabihf

Meta

$ cd rust && git rev-parse HEAD
6d6ae1ffe665610ae235dd95e849248a6741ff0f

cc @alexcrichton

@alexcrichton
Copy link
Member

Weird... we probably have some crazy logic in the configure script which doesn't account for prefixes or something like that.

@Mark-Simulacrum
Copy link
Member

Seems that this is still an issue. However, I don't know whether this actually causes problems with rustbuild. Perhaps @alexcrichton could comment?

With --target=arm-unknown-linux-gnueabihf,arm-unknown-linux-gnueabi
CFG_TARGET           := arm-unknown-linux-gnueabihf
With --target=arm-unknown-linux-gnueabi,arm-unknown-linux-gnueabihf
CFG_TARGET           := arm-unknown-linux-gnueabi arm-unknown-linux-gnueabihf

@alexcrichton
Copy link
Member

Unfortunately not much more than before, probably still the same crazy ./configure logic

@Mark-Simulacrum Mark-Simulacrum added the C-bug Category: This is a bug. label Jul 24, 2017
bors added a commit that referenced this issue Aug 28, 2017
…crum

rustbuild: Rewrite the configure script in Python

This commit rewrites our ancient `./configure` script from shell into Python.
The impetus for this change is to remove `config.mk` which is just a vestige of
the old makefile build system at this point. Instead all configuration is now
solely done through `config.toml`.

The python script allows us to more flexibly program (aka we can use loops
easily) and create a `config.toml` which is based off `config.toml.example`.
This way we can preserve comments and munge various values as we see fit.

It is intended that the configure script here is a drop-in replacement for the
previous configure script, no functional change is intended. Also note that the
rationale for this is also because our build system requires Python, so having a
python script a bit earlier shouldn't cause too many problems.

Closes #40730
Closes #43295
Closes #42255
Closes #38058
Closes #32176
bors added a commit that referenced this issue Aug 28, 2017
…crum

rustbuild: Rewrite the configure script in Python

This commit rewrites our ancient `./configure` script from shell into Python.
The impetus for this change is to remove `config.mk` which is just a vestige of
the old makefile build system at this point. Instead all configuration is now
solely done through `config.toml`.

The python script allows us to more flexibly program (aka we can use loops
easily) and create a `config.toml` which is based off `config.toml.example`.
This way we can preserve comments and munge various values as we see fit.

It is intended that the configure script here is a drop-in replacement for the
previous configure script, no functional change is intended. Also note that the
rationale for this is also because our build system requires Python, so having a
python script a bit earlier shouldn't cause too many problems.

Closes #40730
Closes #43295
Closes #42255
Closes #38058
Closes #32176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
Development

No branches or pull requests

3 participants