Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test time::tests::instant_math fails on Windows (GNU) with +/-1 error #29970

Closed
petrochenkov opened this issue Nov 21, 2015 · 2 comments
Closed

Test time::tests::instant_math fails on Windows (GNU) with +/-1 error #29970

petrochenkov opened this issue Nov 21, 2015 · 2 comments

Comments

@petrochenkov
Copy link
Contributor

Windows 8.1 64-bit / MSYS2 / MinGW-w64

thread '<unnamed>' panicked at 'assertion failed: `(left == right)` (left: `Instant { t: 3793243355088 }`, right: `Instant { t: 3793243355087 }`)', src/libstd\time/mod.rs:252
test time::tests::instant_math ... FAILED

cc @alexcrichton
@alexcrichton
Copy link
Member

Interesting! This is testing the property that the duration between two instants plus the first is the same as the second. Unfortunately this isn't true on Windows due to the +/- one problem on multiple cores.

Have to think about what's the best course of action here.

@alexcrichton alexcrichton mentioned this issue Nov 23, 2015
Closed
@alexcrichton alexcrichton mentioned this issue Nov 23, 2015
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this issue Nov 23, 2015
@alexcrichton
std: Tweak tests of std::time
27ee3fe 
Typical algebra currently doesn't work on the types in std::time currently (see
[this comment][comment]), so tweak the tests to account for this property.

[comment]: rust-lang#29866 (comment)

Closes rust-lang#29970
bors added a commit that referenced this issue Nov 24, 2015
@bors
Auto merge of #30016 - alexcrichton:fix-off-by-one, r=brson
338cdd7 
Typical algebra currently doesn't work on the types in std::time currently (see
[this comment][comment]), so tweak the tests to account for this property.

[comment]: #29866 (comment)

Closes #29970
@petrochenkov
Copy link
Contributor Author

This still fails, btw

thread '<unnamed>' panicked at 'assertion failed: a - Duration::new(0, 1) <= b', src/libstd\time/mod.rs:262

alexcrichton added a commit to alexcrichton/rust that referenced this issue Nov 30, 2015
@alexcrichton
std: Bump time margin in std::time tests
9034440 
I believe that because Windows' unit of resolution is 100ns that this unit of
time will ensure that the assertions will hold true as it's representable in the
native format.

cc rust-lang#29970
@alexcrichton alexcrichton mentioned this issue Nov 30, 2015
Merged
bors added a commit that referenced this issue Dec 1, 2015
@bors
Auto merge of #30118 - alexcrichton:fix-time-again, r=aturon
0bfdedb 
I believe that because Windows' unit of resolution is 100ns that this unit of
time will ensure that the assertions will hold true as it's representable in the
native format.

cc #29970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @petrochenkov