Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust_task::block_locked and rust_task::must_fail_unlocked naming inconsistency #2864

Closed
bblum opened this issue Jul 10, 2012 · 0 comments
Closed

rust_task::block_locked and rust_task::must_fail_unlocked naming inconsistency #2864

bblum opened this issue Jul 10, 2012 · 0 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
0.5

Comments

@bblum
Copy link
Contributor

bblum commented Jul 10, 2012

Both of them are "inner" functions that are usually called by wrappers which take a lock around the call, but sometimes can be called directly if the lock is already held.

"block_locked" means "call this when already locked";
"must_fail_unlocked" means "this function doesn't do any locking"

But they mean the same thing. Clean up their names.
@ghost ghost assigned bblum Jul 10, 2012
@bblum bblum closed this as completed in b897696 Jul 12, 2012
bblum added a commit that referenced this issue Jul 12, 2012
@bblum
Revert linked failure (renaming runtime fns)
3b159c6 
Revert "Rename runtime *_locked() and *_unlocked() fns to *_inner() (closes #2864)"

This reverts commit b897696.
@bblum bblum removed their assignment Jun 16, 2014
RalfJung pushed a commit to RalfJung/rust that referenced this issue May 11, 2023
@bors
Auto merge of rust-lang#2864 - RalfJung:rustup, r=RalfJung
e285f76 
Rustup

My previous rustup PR was broken. I didn't realize that "nothing to commit, working tree clean" meant "I didn't actually do the full pull properly, stop and inspect manually"...
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@adpaco-aws
Fix setup for aarch64-unknown-linux-gnu platform (rust-lang#2864)
8027413 
Fixes setup for the `aarch64-unknown-linux-gnu` platform by adding its
target triple to the list of supported targets in the setup program.

Resolves rust-lang#2863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@bblum