Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot import same impls from two numeric types at once #2716

Closed
bstrie opened this issue Jun 24, 2012 · 3 comments
Closed

Cannot import same impls from two numeric types at once #2716

bstrie opened this issue Jun 24, 2012 · 3 comments
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically
Milestone

Comments

@bstrie
Copy link
Contributor

bstrie commented Jun 24, 2012

There are three impls in int-template.rs and uint-template.rs that apply to all numeric types. Until recently, if you tried to do this:

import int::num;
import i8::num;

you'd receive "error: duplicate definition of type num". d14d415 fixed this for the particular case of the num impl, but trying to duplicate the process for the eq and ord impls gives weird errors in libstd/sort.rs that I'm hoping the resolve rewrite will, er, resolve. It won't be possible to automatically export the eq and ord impls on numeric types until this is fixed.

@brson
Copy link
Contributor

brson commented Jun 25, 2012

I've done some poking and can't get away from 'duplicate definition of eq' errors.

@catamorphism
Copy link
Contributor

I'll consider this blocked on #1935

@bstrie
Copy link
Contributor Author

bstrie commented Jul 16, 2012

Fixed by new resolve.

celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
I would like to incorporate a few suggestions to the RFC process and template:
  1. Suggest that the first RFC revision should not include implementation details. Thanks @feliperodri for the suggestion. 
  2. Change the template to (hopefully) clarify what should go in each section. @JustusAdam any suggestions?
  3. Change the template to clarify that open questions and future work should be simple lists.
  4. Replace `--enable-unstable` by `-Z` flag.

The main goal is to try to speed up the process by reducing the scope of the RFC document, breaking it down into multiple steps, and even reduce the need for an RFC entirely.

Co-authored-by: Felipe R. Monteiro <rms.felipe@gmail.com>
Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically
Projects
None yet
Development

No branches or pull requests

3 participants