Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement syntax extensions for #file and #line #2245

Closed
catamorphism opened this issue Apr 19, 2012 · 4 comments
Closed

Implement syntax extensions for #file and #line #2245

catamorphism opened this issue Apr 19, 2012 · 4 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@catamorphism
Copy link
Contributor

Implement a syntax extension for #file (expanding to the name of the file that the extension is used in) and #line (expanding to the line number that the extension is used on). This is needed for #2228 and #2232.
This was referenced Apr 19, 2012
Closed
Closed
@bstrie
Copy link
Contributor

bstrie commented Apr 23, 2012

Is this also needed for #554?

@catamorphism
Copy link
Contributor Author

@Wensleydale -- I don't think it's needed, strictly? Log doesn't seem to print out the file/line number where the log expression was right now, though it would be nice if it did.

@brson
Copy link
Contributor

brson commented May 23, 2012

@paulstansifer I think this is done?.

@paulstansifer
Copy link
Contributor

Closed by 88f4d06.

bors added a commit to rust-lang-ci/rust that referenced this issue Sep 22, 2022
@bors
Auto merge of rust-lang#2245 - saethlin:color-always, r=RalfJung
9e2dac4 
Actually pass through the request for --color=always

rust-lang/miri#2243 actually doesn't work 😂

The suggestion to split on `,` was good but `arg` is actually the whole `--json=diagnostic-rendered-ansi,artifacts,future-incompat
`, and of course I didn't test that change locally and we have no test for this in CI.

Therefore, I would like some guidance on making a test for this because I'm going to rely on this working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@paulstansifer @brson @catamorphism @bstrie