Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework make tidy #2188

Closed
brson opened this issue Apr 12, 2012 · 4 comments
Closed

Rework make tidy #2188

brson opened this issue Apr 12, 2012 · 4 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@brson
Copy link
Contributor

brson commented Apr 12, 2012

Our tidy script takes all the files to look at as arguments and we keep hitting the maximum number of arguments.

@ghost ghost assigned brson Apr 12, 2012
@emberian
Copy link
Member

@brson don't think this is an issue anymore?

@pnkfelix
Copy link
Member

part of #8058 (or at least it might be, sounds like it might not be an issue any more; I'll have to check I guess)

@emillon
Copy link
Contributor

emillon commented Jul 31, 2013

In mk/tests.mk, tidy.py is invoked through xargs -n 10, effectively limiting the number of arguments.

However, as an experiment, I rewrote the find + grep + filter_out logic inside tidy.py using os.walk in order to limit the creation of child processes. It's 30% faster (5.1s instead of 7.2s) but I think that it's way less readable: see emillon/rust@f8344f0c (not ready yet).

@alexcrichton
Copy link
Member

We seem to be managing ok with the system we have today. As @emillon pointed out, we're not hitting the maximum number of arguments any more because of xargs, so there doesn't appear to be any pressing matter any more.

celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

5 participants