Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularize handling of x64 ABI rules in native.rs #2034

Closed
graydon opened this issue Mar 20, 2012 · 4 comments
Closed

Modularize handling of x64 ABI rules in native.rs #2034

graydon opened this issue Mar 20, 2012 · 4 comments
Labels
A-codegen Area: Code generation C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot.

Comments

@graydon
Copy link
Contributor

graydon commented Mar 20, 2012

Currently native.rs has a lot of alt switching on whether or not we're generating calls to x64-ABI or not. This should be factored into arch-specific and arch-neutral pieces, with x64 being only one such arch.
@ghost ghost assigned graydon Mar 20, 2012
@pnkfelix
Copy link
Member

Not critical for 0.6; de-milestoning

@sanxiyn
Copy link
Member

sanxiyn commented Mar 22, 2013

@crabtw, didn't #4590 fix this?

@crabtw
Copy link
Contributor

crabtw commented Mar 22, 2013

@sanxiyn yes, that should fix this issue.

@pcwalton
Copy link
Contributor

Fixed.

@graydon graydon removed their assignment Jun 16, 2014
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@adpaco-aws
Report bookrunner failures for each stage (rust-lang#2034)
e854c74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@graydon @crabtw @sanxiyn @pcwalton @pnkfelix