Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spurious test out-of-stack test failure on Android #20004

Open
aturon opened this issue Dec 19, 2014 · 7 comments
Open

Spurious test out-of-stack test failure on Android #20004

aturon opened this issue Dec 19, 2014 · 7 comments
Labels
A-codegen Area: Code generation C-bug Category: This is a bug. I-flaky-test Issue: A test is flaky/unreliable/spuriously fails O-android Operating system: Android T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@aturon
Copy link
Member

aturon commented Dec 19, 2014

See https://gist.github.com/aturon/6c03914f968084548cd6 for an example. @alexcrichton dug into this and found strange behavior but wasn't able to make sense of it.

The test is going to be marked ignore on android for the time being.
@aturon
Copy link
Member Author

aturon commented Dec 19, 2014

@alexcrichton can you fill out the details here?

@alexcrichton
Copy link
Member

The best that I could ever figure out here was that it may be some form of codegen bug, but I could never track it down. The failure mode here was that while panicking a debug_assert! was trigged in a RefCell borrow, causing everything to go downhill from there, eventually causing the oom handler to run.

I stepped through into the destructor of BorrowRefMut, but the self pointer was off by ~16 bytes. The memory of where I thought the RefCell resided looked totally ok, but the pointer inside of BorrowRefMut was way off.

I may have been just been tracing wrong, though. I also saw really weird things like strex failing in a single-threaded context whenever I used stepi in gdb, which I would not expect to happen!

aturon added a commit to aturon/rust that referenced this issue Dec 19, 2014
@aturon
Disable stack overflow test on android, which seems to be failing spu…
f4c0c0f 
…riously.

cc rust-lang#20004
@kmcallister kmcallister added O-android Operating system: Android A-codegen Area: Code generation labels Jan 16, 2015
@steveklabnik
Copy link
Member

Triage: over a year later, no changes that I'm aware of, and this is still ignored on android.

@Mark-Simulacrum Mark-Simulacrum added the A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) label Apr 29, 2017
@Mark-Simulacrum
Copy link
Member

Filed #41618 to unignore the test and see how it goes. If you see this test fail, please either file a PR to revert mine (once it lands) or let me know and I'll do so.

@Mark-Simulacrum Mark-Simulacrum mentioned this issue Apr 29, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 29, 2017
@frewsxcv
Rollup merge of rust-lang#41618 - Mark-Simulacrum:unignore-20004, r=a…
f99a1d5 
…turon

Unignore android for previously spuriously failing test.

Will see if this start failing again, in which case we'll re-ignore the test.

In theory, rust-lang#20004 could be fixed by this. I've left that open because it's possible that this will resume the previous spurious failures, and marked it as A-spurious so people doing PR triage catch that. I will leave a comment there saying that if we see failures from this test on android, we should re-ignore it.
@Mark-Simulacrum
Copy link
Member

#41618 failed, this is not ready to be re-enabled.

@Mark-Simulacrum Mark-Simulacrum added C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 22, 2017
@cuviper cuviper mentioned this issue Jan 30, 2018
Closed
@steveklabnik
Copy link
Member

Triage: test still disabled https://github.com/rust-lang/rust/blob/master/src/test/run-pass/out-of-stack.rs#L3

@tmandry tmandry mentioned this issue Sep 20, 2022
Merged
@Enselic Enselic added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 18, 2023
@jieyouxu jieyouxu added I-flaky-test Issue: A test is flaky/unreliable/spuriously fails and removed A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) labels Nov 26, 2024
@jieyouxu
Copy link
Member

Triage (2025): test still disabled on Android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation C-bug Category: This is a bug. I-flaky-test Issue: A test is flaky/unreliable/spuriously fails O-android Operating system: Android T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@steveklabnik @alexcrichton @Enselic @kmcallister @aturon @Mark-Simulacrum @jieyouxu