You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Someone on hacker news pointed out that bad things could potentially happen if the running of curl https://static.rust-lang.org/rust.sh | sh gets truncated on a bad line. We should audit the code to make sure that can't happen. Maybe we could write the actual rustup.sh and verify it with a checksum before we execute it?
The text was updated successfully, but these errors were encountered:
This would theoretically be resolved by putting the whole script into a function that then gets executed at the very end, so nothing happens until that is reached, e.g.
This closesrust-lang#19168. It's possible that if the downloading of `rustup.sh`
is interrupted, bad things could happen, such as running a naked
"rm -rf /" instead of "rm -rf /path/to/tmpdir". This wraps rustup.sh's
functionality in a function that gets called at the last time that should
protect us from these truncation errors.
This closes#19168.
Please be careful reviewing this since this gets used all over the place. I've tested all the options and everything appears to be working though.
Someone on hacker news pointed out that bad things could potentially happen if the running of
curl https://static.rust-lang.org/rust.sh | sh
gets truncated on a bad line. We should audit the code to make sure that can't happen. Maybe we could write the actual rustup.sh and verify it with a checksum before we execute it?The text was updated successfully, but these errors were encountered: