-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PartialOrd derving broken for slices #18738
Comments
Offending code: #[inline]
fn partial_cmp(&self, __arg_0: &Version) ->
::std::option::Option<::std::cmp::Ordering> {
match *__arg_0 {
Version { vender_info: ref __self_1_0 } =>
match *self {
Version { vender_info: ref __self_0_0 } => {
let __test = (*__self_0_0).partial_cmp(&(*__self_1_0));
if __test == ::std::option::Some(::std::cmp::Equal) {
::std::option::Some(::std::cmp::Equal)
} else { __test }
}
},
}
}
|
@cmr See #15689 (comment) I'll probably send a fix later today. |
This still seems broken: #[deriving(Eq, PartialEq, Ord, PartialOrd)]
struct Foo(&'static str);
|
brendanzab
added a commit
to brendanzab/gfx-rs
that referenced
this issue
Dec 6, 2014
rust-lang/rust#18738 still seems broken, but this makes the impls a tad less ugly...
@bjz Hmm, |
Cheers! |
lnicola
pushed a commit
to lnicola/rust
that referenced
this issue
Dec 23, 2024
fix: Properly check if workspace flychecking is allowed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Removing the
PartialOrd
deriving fixes it.The text was updated successfully, but these errors were encountered: