Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up and down arrows do not work in search. #15038

Closed
zzmp opened this issue Jun 19, 2014 · 1 comment
Closed

Up and down arrows do not work in search. #15038

zzmp opened this issue Jun 19, 2014 · 1 comment

Comments

@zzmp
Copy link
Contributor

zzmp commented Jun 19, 2014

They are currently documented, but #15037 will change that to tabs, which do work.

Unless they are to be fixed, there is dead code in the static main.js to make them work. Search on e.which (assuming #15037 goes through, otherwise, search on e.keyCode) to find the dead code.

@huonw
Copy link
Member

huonw commented Jun 19, 2014

This looks like a dupe: #15011

@huonw huonw closed this as completed Jun 19, 2014
bors added a commit that referenced this issue Jun 19, 2014
Continuing from #15012, this makes four changes to the `rustdoc` static files.

- Change the placeholder text of the search bar to `Click or press 'S' to search, '?' for more options...` to make keyboard hotkeys more apparent (capitalizing the `S` to match the help text).
- Change the `main.js` file to use browser-normalized key codes (`e.which`, from `jQuery`), instead of `e.keyCode`.
- Change the key code for `?` to be the correct `191` instead of `188`, so that the hotkey works to bring up search information.
- Change the search information to display `tab` and `shift+tab` instead of `up` and `down`, as those do not yet work outside of Firefox (see #15011). Also, adjust the height so it does not cut off the help text.

<s>I've also opened up #15038 about the non-functional `up` and `down` functionality, although this does nothing to fix it.</s>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants