Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x86_64 msvc: warning: rustc_llvm@0.0.0: Inherited flag "/Oy-" is not supported by the currently used CC #134657

Closed
jieyouxu opened this issue Dec 22, 2024 · 4 comments · Fixed by rust-lang/cc-rs#1330 or #134869
Closed

x86_64 msvc: warning: rustc_llvm@0.0.0: Inherited flag "/Oy-" is not supported by the currently used CC #134657

jieyouxu opened this issue Dec 22, 2024 · 4 comments · Fixed by rust-lang/cc-rs#1330 or #134869
Labels
C-bug Category: This is a bug. O-windows-msvc Toolchain: MSVC, Operating system: Windows T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Dec 22, 2024 •
edited
Loading

On my native x86_64-pc-windows-msvc environment, I am observing the warnings:

   Compiling rustc_ast_passes v0.0.0 (X:\repos\rust\compiler\rustc_ast_passes)
   Compiling rustc_expand v0.0.0 (X:\repos\rust\compiler\rustc_expand)
   Compiling rustc_builtin_macros v0.0.0 (X:\repos\rust\compiler\rustc_builtin_macros)
warning: rustc_llvm@0.0.0: Inherited flag "/Oy-" is not supported by the currently used CC
warning: rustc_llvm@0.0.0: Inherited flag "/Oy-" is not supported by the currently used CC
warning: rustc_llvm@0.0.0: Inherited flag "/Oy-" is not supported by the currently used CC
warning: rustc_llvm@0.0.0: Inherited flag "/Oy-" is not supported by the currently used CC
warning: rustc_llvm@0.0.0: Inherited flag "/Oy-" is not supported by the currently used CC
warning: rustc_llvm@0.0.0: Inherited flag "/Oy-" is not supported by the currently used CC
   Compiling rustc_infer v0.0.0 (X:\repos\rust\compiler\rustc_infer)
   Compiling rustc_mir_dataflow v0.0.0 (X:\repos\rust\compiler\rustc_mir_dataflow)
   Compiling rustc_metadata v0.0.0 (X:\repos\rust\compiler\rustc_metadata)
   Compiling rustc_pattern_analysis v0.0.0 (X:\repos\rust\compiler\rustc_pattern_analysis)

This is probably related to the cc bumps we done recently... FYI @clubby789 :ferrisClueless: I have not tried to bisect this.
@jieyouxu jieyouxu added C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 22, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 22, 2024
@jieyouxu jieyouxu added O-windows-msvc Toolchain: MSVC, Operating system: Windows and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Dec 22, 2024
@clubby789
Copy link
Contributor

Yeah these warnings come from cc trying to pass through the equivalent flags (observed while debugging the recent bump). cc probes them and emits this warning if it can't pass the flags through.

Not sure if this is necessarily something to worry about - maybe cc could provide more options to configure this behaviour

@clubby789
Copy link
Contributor

/Oy enables frame-pointer omission and /Oy- disables omission. In x64 compilers, /Oy and /Oy- are not available.

Hmm, maybe CC should be applying some more heuristics to these inherited flags

@jieyouxu
Copy link
Member Author

Yeah, I just wanted to track it in case it's problematic.

@clubby789 clubby789 mentioned this issue Dec 22, 2024
Merged
@clubby789
Copy link
Contributor

Oops - probably want to keep this open until it makes it into a release that we can pull in.

@clubby789 clubby789 reopened this Dec 22, 2024
@clubby789 clubby789 mentioned this issue Dec 29, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 29, 2024
@bors
Auto merge of rust-lang#134869 - clubby789:cc-bump, r=<try>
7805c92 
Bump compiler cc

Fixes rust-lang#134657
Pulls in rust-lang#134657

try-job: x86_64-msvc
Zalathar added a commit to Zalathar/rust that referenced this issue Dec 29, 2024
@Zalathar
Rollup merge of rust-lang#134869 - clubby789:cc-bump, r=jieyouxu
7768c39 
Bump compiler cc

Fixes rust-lang#134657
Pulls in rust-lang/cc-rs#1330

try-job: x86_64-msvc
@bors bors closed this as completed in ea2851b Dec 29, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Dec 29, 2024
@rust-timer
Unrolled build for rust-lang#134869
b05a377 
Rollup merge of rust-lang#134869 - clubby789:cc-bump, r=jieyouxu

Bump compiler cc

Fixes rust-lang#134657
Pulls in rust-lang/cc-rs#1330

try-job: x86_64-msvc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. O-windows-msvc Toolchain: MSVC, Operating system: Windows T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't inherit the /Oy flag for 64-bit targets clubby789/cc-rs
Bump compiler cc clubby789/rust
3 participants
@clubby789 @jieyouxu @rustbot