-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc 1.83 lexing regression in the 2015 edition: 'r#x'y #133479
Labels
A-parser
Area: The parsing of Rust source code to an AST
C-bug
Category: This is a bug.
P-medium
Medium priority
regression-untriaged
Untriaged performance or correctness regression.
Comments
mattheww
added
C-bug
Category: This is a bug.
regression-untriaged
Untriaged performance or correctness regression.
labels
Nov 25, 2024
rustbot
added
I-prioritize
Issue: Indicates that prioritization has been requested for this issue.
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
labels
Nov 25, 2024
I'm tempted to say that this is a purely theoretical regression, and we should perhaps fix it in 1.84 but it's possibly a bit too late for 1.83? Especially because I'm not certain how to prepare a fix for this other than perhaps reverting raw lifetime functionality altogether. |
saethlin
removed
the
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
label
Nov 26, 2024
compiler-errors
added
the
A-parser
Area: The parsing of Rust source code to an AST
label
Nov 26, 2024
WG-prioritization assigning priority (Zulip discussion). @rustbot label -I-prioritize +P-medium |
rustbot
added
P-medium
Medium priority
and removed
I-prioritize
Issue: Indicates that prioritization has been requested for this issue.
labels
Nov 26, 2024
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Dec 1, 2024
…ebank Only error raw lifetime followed by `\'` in edition 2021+ Fixes rust-lang#133479 cc rust-lang#132341 I think this fixes a purely theoretical regression since it only affects edition 2015 (who is using that?) and only in the very rare case of a raw lifetime followed immediately by a lifetime like `'r#a'r`.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Dec 1, 2024
Rollup merge of rust-lang#133482 - compiler-errors:raw-lt-tick, r=estebank Only error raw lifetime followed by `\'` in edition 2021+ Fixes rust-lang#133479 cc rust-lang#132341 I think this fixes a purely theoretical regression since it only affects edition 2015 (who is using that?) and only in the very rare case of a raw lifetime followed immediately by a lifetime like `'r#a'r`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-parser
Area: The parsing of Rust source code to an AST
C-bug
Category: This is a bug.
P-medium
Medium priority
regression-untriaged
Untriaged performance or correctness regression.
rustc 1.82 accepts forms like
'r#x'y
in the 2015 edition, but rustc 1.83 (beta) rejects them.As I understand it, #126452 wasn't intended to have any effect on the 2015 edition.
playground
I think this is fallout from the beta-backport of #132341.
The text was updated successfully, but these errors were encountered: