-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/ui/associated-consts/issue-93775.rs
seems to be flaky
#132111
Comments
cc #93775 |
I don't have a good solution to this, having the test being flaky is not ideal, but neither is outright deleting this because this is a regression test for the original issue that segfaulted. |
This test seems to be quite flaky. See: - rust-lang#132111 - rust-lang#133432
…atrieb Disable `tests/ui/associated-consts/issue-93775.rs` on windows msvc This test seems to be quite flaky. See: - rust-lang#132111 - rust-lang#133432
Rollup merge of rust-lang#134372 - jieyouxu:disable-flaky-test, r=Noratrieb Disable `tests/ui/associated-consts/issue-93775.rs` on windows msvc This test seems to be quite flaky. See: - rust-lang#132111 - rust-lang#133432
Is it reasonable to add |
I haven't figured out why this particular test fails on msvc sometimes, and I think since it's currently disabled on msvc, it's better to figure out why it was failing in the first place. |
Here is a recursive function, and I think this issue remains unresolved. rust/compiler/rustc_middle/src/ty/print/mod.rs Lines 166 to 169 in 73c278f
|
Move test rust-lang#93775 to crashes Closes rust-lang#132111. Closes rust-lang#133432. Re-opens rust-lang#93775. I think this test case is flaky because the recursive calls happen to hit the upper limit of the call stack. IMO, this may not be an issue, as it's reasonable for overly complex code to require additional build configurations (such as increasing the call stack size). r? jieyouxu try-job: x86_64-msvc try-job: i686-msvc
Move test rust-lang#93775 to crashes Closes rust-lang#132111. Closes rust-lang#133432. Re-opens rust-lang#93775. I think this test case is flaky because the recursive calls happen to hit the upper limit of the call stack. IMO, this may not be an issue, as it's reasonable for overly complex code to require additional build configurations (such as increasing the call stack size). r? jieyouxu try-job: x86_64-msvc try-job: i686-msvc
Move test rust-lang#93775 to crashes Closes rust-lang#132111. Closes rust-lang#133432. Re-opens rust-lang#93775. I think this test case is flaky because the recursive calls happen to hit the upper limit of the call stack. IMO, this may not be an issue, as it's reasonable for overly complex code to require additional build configurations (such as increasing the call stack size). r? jieyouxu try-job: x86_64-msvc try-job: i686-msvc
I was modifying the compiler for unrelated changes on
x86_64-pc-windows-msvc
, and thetests/ui/associated-consts/issue-93775.rs
ui test seemingly randomly failed, a rerun with nothing changed made the test pass, and now I can't reproduce it easily.The text was updated successfully, but these errors were encountered: