Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/ui/associated-consts/issue-93775.rs seems to be flaky #132111

Closed
jieyouxu opened this issue Oct 24, 2024 · 5 comments · Fixed by #134608
Closed

tests/ui/associated-consts/issue-93775.rs seems to be flaky #132111

jieyouxu opened this issue Oct 24, 2024 · 5 comments · Fixed by #134608
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. I-flaky-test Issue: A test is flaky/unreliable/spuriously fails T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

Image

I was modifying the compiler for unrelated changes on x86_64-pc-windows-msvc, and the tests/ui/associated-consts/issue-93775.rs ui test seemingly randomly failed, a rerun with nothing changed made the test pass, and now I can't reproduce it easily.

@jieyouxu jieyouxu added A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 24, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 24, 2024
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 24, 2024
@jieyouxu
Copy link
Member Author

cc #93775

@jieyouxu
Copy link
Member Author

I don't have a good solution to this, having the test being flaky is not ideal, but neither is outright deleting this because this is a regression test for the original issue that segfaulted.

@jieyouxu jieyouxu added the I-flaky-test Issue: A test is flaky/unreliable/spuriously fails label Nov 25, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this issue Dec 16, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 16, 2024
…atrieb

Disable `tests/ui/associated-consts/issue-93775.rs` on windows msvc

This test seems to be quite flaky. See:

- rust-lang#132111
- rust-lang#133432
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Dec 16, 2024
Rollup merge of rust-lang#134372 - jieyouxu:disable-flaky-test, r=Noratrieb

Disable `tests/ui/associated-consts/issue-93775.rs` on windows msvc

This test seems to be quite flaky. See:

- rust-lang#132111
- rust-lang#133432
@DianQK
Copy link
Member

DianQK commented Dec 21, 2024

Is it reasonable to add //@ retry=1 directive?

@jieyouxu
Copy link
Member Author

Is it reasonable to add //@ retry=1 directive?

I haven't figured out why this particular test fails on msvc sometimes, and I think since it's currently disabled on msvc, it's better to figure out why it was failing in the first place.

@DianQK
Copy link
Member

DianQK commented Dec 21, 2024

Is it reasonable to add //@ retry=1 directive?

I haven't figured out why this particular test fails on msvc sometimes, and I think since it's currently disabled on msvc, it's better to figure out why it was failing in the first place.

Here is a recursive function, and I think this issue remains unresolved.

return self.path_generic_args(
|cx| cx.print_def_path(def_id, parent_args),
args,
);

bors added a commit to rust-lang-ci/rust that referenced this issue Dec 21, 2024
Move test rust-lang#93775 to crashes

Closes rust-lang#132111. Closes rust-lang#133432. Re-opens rust-lang#93775.

I think this test case is flaky because the recursive calls happen to hit the upper limit of the call stack.

IMO, this may not be an issue, as it's reasonable for overly complex code to require additional build configurations (such as increasing the call stack size).

r? jieyouxu

try-job: x86_64-msvc
try-job: i686-msvc
DianQK added a commit to DianQK/rust that referenced this issue Dec 21, 2024
Move test rust-lang#93775 to crashes

Closes rust-lang#132111. Closes rust-lang#133432. Re-opens rust-lang#93775.

I think this test case is flaky because the recursive calls happen to hit the upper limit of the call stack.

IMO, this may not be an issue, as it's reasonable for overly complex code to require additional build configurations (such as increasing the call stack size).

r? jieyouxu

try-job: x86_64-msvc
try-job: i686-msvc
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Dec 21, 2024
Move test rust-lang#93775 to crashes

Closes rust-lang#132111. Closes rust-lang#133432. Re-opens rust-lang#93775.

I think this test case is flaky because the recursive calls happen to hit the upper limit of the call stack.

IMO, this may not be an issue, as it's reasonable for overly complex code to require additional build configurations (such as increasing the call stack size).

r? jieyouxu

try-job: x86_64-msvc
try-job: i686-msvc
@bors bors closed this as completed in 66bb586 Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. I-flaky-test Issue: A test is flaky/unreliable/spuriously fails T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants