Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for rename from "object safe" to "dyn compatible" #130852

Open
7 of 12 tasks
traviscross opened this issue Sep 25, 2024 · 1 comment
Open
7 of 12 tasks

Tracking issue for rename from "object safe" to "dyn compatible" #130852

traviscross opened this issue Sep 25, 2024 · 1 comment
Assignees
@fmease
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-dyn-compatibility Area: Dyn compatibility (formerly: object safety) C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@traviscross
Copy link
Contributor

traviscross commented Sep 25, 2024 •
edited by fmease
Loading

This is a tracking issue for the change to call traits that are compatible with dyn from "object safe" to "dyn compatible".

About tracking issues

Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

cc @rust-lang/lang @fmease
@traviscross traviscross added A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-lang Relevant to the language team, which will review and decide on the PR/issue. labels Sep 25, 2024
@traviscross traviscross mentioned this issue Sep 25, 2024
Closed
@traviscross traviscross changed the title Tracking issue for rename of traits from "object safe" to "dyn compatibie" Tracking issue for rename from "object safe" to "dyn compatibie" Sep 25, 2024
@fmease fmease changed the title Tracking issue for rename from "object safe" to "dyn compatibie" Tracking issue for rename from "object safe" to "dyn compatible" Sep 25, 2024
This was referenced Sep 27, 2024
Merged
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Sep 27, 2024
@matthiaskrgr
Rollup merge of rust-lang#130826 - fmease:compiler-mv-obj-safe-dyn-co…
a935064 
…mpat, r=compiler-errors

Compiler: Rename "object safe" to "dyn compatible"

Completed T-lang FCP: rust-lang/lang-team#286 (comment).
Tracking issue: rust-lang#130852

Excludes `compiler/rustc_codegen_cranelift` (to be filed separately).
Includes Stable MIR.

Regarding https://github.com/rust-lang/rust/labels/relnotes, I guess I will manually open a https://github.com/rust-lang/rust/labels/relnotes-tracking-issue since this change affects everything (compiler, library, tools, docs, books, everyday language).

r? ghost
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Sep 28, 2024
@rust-timer
Unrolled build for rust-lang#130826
fcb7e61 
Rollup merge of rust-lang#130826 - fmease:compiler-mv-obj-safe-dyn-compat, r=compiler-errors

Compiler: Rename "object safe" to "dyn compatible"

Completed T-lang FCP: rust-lang/lang-team#286 (comment).
Tracking issue: rust-lang#130852

Excludes `compiler/rustc_codegen_cranelift` (to be filed separately).
Includes Stable MIR.

Regarding https://github.com/rust-lang/rust/labels/relnotes, I guess I will manually open a https://github.com/rust-lang/rust/labels/relnotes-tracking-issue since this change affects everything (compiler, library, tools, docs, books, everyday language).

r? ghost
@fmease fmease mentioned this issue Oct 3, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 9, 2024
@matthiaskrgr
Rollup merge of rust-lang#130827 - fmease:library-mv-obj-save-dyn-com…
627d0b4 
…pat, r=ibraheemdev

Library: Rename "object safe" to "dyn compatible"

Completed T-lang FCP: rust-lang/lang-team#286 (comment).
Tracking issue: rust-lang#130852

Regarding https://github.com/rust-lang/rust/labels/relnotes, I guess I will manually open a https://github.com/rust-lang/rust/labels/relnotes-tracking-issue since this change affects everything (compiler, library, tools, docs, books, everyday language).

r? ghost
@fmease fmease self-assigned this Oct 9, 2024
@fmease fmease mentioned this issue Oct 9, 2024
Merged
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 10, 2024
@rust-timer
Unrolled build for rust-lang#130827
270f1ba 
Rollup merge of rust-lang#130827 - fmease:library-mv-obj-save-dyn-compat, r=ibraheemdev

Library: Rename "object safe" to "dyn compatible"

Completed T-lang FCP: rust-lang/lang-team#286 (comment).
Tracking issue: rust-lang#130852

Regarding https://github.com/rust-lang/rust/labels/relnotes, I guess I will manually open a https://github.com/rust-lang/rust/labels/relnotes-tracking-issue since this change affects everything (compiler, library, tools, docs, books, everyday language).

r? ghost
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 10, 2024
@matthiaskrgr
Rollup merge of rust-lang#131475 - fmease:compiler-mv-obj-safe-dyn-co…
d5624a2 
…mpat-2, r=jieyouxu

Compiler & its UI tests: Rename remaining occurrences of "object safe" to "dyn compatible"

Follow-up to rust-lang#130826.
Part of rust-lang#130852.

1. 1st commit: Fix stupid oversights. Should've been part of rust-lang#130826.
2. 2nd commit: Rename the unstable feature `object_safe_for_dispatch` to `dyn_compatible_for_dispatch`. Might not be worth the churn, you decide.
3. 3rd commit: Apply the renaming to all UI tests (contents and paths).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 10, 2024
@matthiaskrgr
Rollup merge of rust-lang#131475 - fmease:compiler-mv-obj-safe-dyn-co…
33053d3 
…mpat-2, r=jieyouxu

Compiler & its UI tests: Rename remaining occurrences of "object safe" to "dyn compatible"

Follow-up to rust-lang#130826.
Part of rust-lang#130852.

1. 1st commit: Fix stupid oversights. Should've been part of rust-lang#130826.
2. 2nd commit: Rename the unstable feature `object_safe_for_dispatch` to `dyn_compatible_for_dispatch`. Might not be worth the churn, you decide.
3. 3rd commit: Apply the renaming to all UI tests (contents and paths).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 10, 2024
@matthiaskrgr
Rollup merge of rust-lang#131475 - fmease:compiler-mv-obj-safe-dyn-co…
0ebf0ef 
…mpat-2, r=jieyouxu

Compiler & its UI tests: Rename remaining occurrences of "object safe" to "dyn compatible"

Follow-up to rust-lang#130826.
Part of rust-lang#130852.

1. 1st commit: Fix stupid oversights. Should've been part of rust-lang#130826.
2. 2nd commit: Rename the unstable feature `object_safe_for_dispatch` to `dyn_compatible_for_dispatch`. Might not be worth the churn, you decide.
3. 3rd commit: Apply the renaming to all UI tests (contents and paths).
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Oct 10, 2024
@workingjubilee
Rollup merge of rust-lang#131475 - fmease:compiler-mv-obj-safe-dyn-co…
39142ee 
…mpat-2, r=jieyouxu

Compiler & its UI tests: Rename remaining occurrences of "object safe" to "dyn compatible"

Follow-up to rust-lang#130826.
Part of rust-lang#130852.

1. 1st commit: Fix stupid oversights. Should've been part of rust-lang#130826.
2. 2nd commit: Rename the unstable feature `object_safe_for_dispatch` to `dyn_compatible_for_dispatch`. Might not be worth the churn, you decide.
3. 3rd commit: Apply the renaming to all UI tests (contents and paths).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 10, 2024
@matthiaskrgr
Rollup merge of rust-lang#131475 - fmease:compiler-mv-obj-safe-dyn-co…
fa3dff3 
…mpat-2, r=jieyouxu

Compiler & its UI tests: Rename remaining occurrences of "object safe" to "dyn compatible"

Follow-up to rust-lang#130826.
Part of rust-lang#130852.

1. 1st commit: Fix stupid oversights. Should've been part of rust-lang#130826.
2. 2nd commit: Rename the unstable feature `object_safe_for_dispatch` to `dyn_compatible_for_dispatch`. Might not be worth the churn, you decide.
3. 3rd commit: Apply the renaming to all UI tests (contents and paths).
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 10, 2024
@rust-timer
Unrolled build for rust-lang#131475
788e88a 
Rollup merge of rust-lang#131475 - fmease:compiler-mv-obj-safe-dyn-compat-2, r=jieyouxu

Compiler & its UI tests: Rename remaining occurrences of "object safe" to "dyn compatible"

Follow-up to rust-lang#130826.
Part of rust-lang#130852.

1. 1st commit: Fix stupid oversights. Should've been part of rust-lang#130826.
2. 2nd commit: Rename the unstable feature `object_safe_for_dispatch` to `dyn_compatible_for_dispatch`. Might not be worth the churn, you decide.
3. 3rd commit: Apply the renaming to all UI tests (contents and paths).
This was referenced Oct 12, 2024
Merged
Merged
Kijewski added a commit to Kijewski/rinja that referenced this issue Oct 12, 2024
@Kijewski
"object safe" is now "dyn-compatible"
9e78d13 
The phrase was changed in
<rust-lang/rust#130852>.
@Kijewski Kijewski mentioned this issue Oct 12, 2024
Draft
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 16, 2024
@matthiaskrgr
Rollup merge of rust-lang#131594 - fmease:rustdoc-mv-obj-safe-dyn-com…
7047748 
…pat, r=notriddle

rustdoc: Rename "object safe" to "dyn compatible"

Supersedes rust-lang#126554:

1. In line with [T-lang's latest resolution](rust-lang/lang-team#286 (comment)).
2. More comprehensive: Not only updates user-facing text but also source code.

Part of rust-lang#130852.

Doesn't update rustdoc-JSON (will be filed separately).

r? `@notriddle` (rust-lang/lang-team#286) `@GuillaumeGomez` (for visibility)
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 16, 2024
@rust-timer
Unrolled build for rust-lang#131594
4332a61 
Rollup merge of rust-lang#131594 - fmease:rustdoc-mv-obj-safe-dyn-compat, r=notriddle

rustdoc: Rename "object safe" to "dyn compatible"

Supersedes rust-lang#126554:

1. In line with [T-lang's latest resolution](rust-lang/lang-team#286 (comment)).
2. More comprehensive: Not only updates user-facing text but also source code.

Part of rust-lang#130852.

Doesn't update rustdoc-JSON (will be filed separately).

r? `@notriddle` (rust-lang/lang-team#286) `@GuillaumeGomez` (for visibility)
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 17, 2024
@bors
Auto merge of rust-lang#131595 - fmease:rustdoc-json-mv-obj-safe-dyn-…
33d17c2 
…compat, r=aDotInTheVoid

rustdoc-JSON: Rename "object safe" to "dyn compatible"

~~Blocked: Sits atop rust-lang#131594. Only the last commit is relevant.~~ (rebased)

Part of rust-lang#130852.

r? aDotInTheVoid or rustdoc
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Oct 17, 2024
@matthiaskrgr
Rollup merge of #130827 - fmease:library-mv-obj-save-dyn-compat, r=ib…
9080e9f 
…raheemdev

Library: Rename "object safe" to "dyn compatible"

Completed T-lang FCP: rust-lang/lang-team#286 (comment).
Tracking issue: rust-lang/rust#130852

Regarding https://github.com/rust-lang/rust/labels/relnotes, I guess I will manually open a https://github.com/rust-lang/rust/labels/relnotes-tracking-issue since this change affects everything (compiler, library, tools, docs, books, everyday language).

r? ghost
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 17, 2024
@bors
Auto merge of rust-lang#131595 - fmease:rustdoc-json-mv-obj-safe-dyn-…
ec3cb64 
…compat, r=aDotInTheVoid

rustdoc-JSON: Rename "object safe" to "dyn compatible"

~~Blocked: Sits atop rust-lang#131594. Only the last commit is relevant.~~ (rebased)

Part of rust-lang#130852.

r? aDotInTheVoid or rustdoc
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 17, 2024
@matthiaskrgr
Rollup merge of rust-lang#131595 - fmease:rustdoc-json-mv-obj-safe-dy…
f6b699c 
…n-compat, r=aDotInTheVoid

rustdoc-JSON: Rename "object safe" to "dyn compatible"

~~Blocked: Sits atop rust-lang#131594. Only the last commit is relevant.~~ (rebased)

Part of rust-lang#130852.

r? aDotInTheVoid or rustdoc
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 17, 2024
@rust-timer
Unrolled build for rust-lang#131595
71bd0b7 
Rollup merge of rust-lang#131595 - fmease:rustdoc-json-mv-obj-safe-dyn-compat, r=aDotInTheVoid

rustdoc-JSON: Rename "object safe" to "dyn compatible"

~~Blocked: Sits atop rust-lang#131594. Only the last commit is relevant.~~ (rebased)

Part of rust-lang#130852.

r? aDotInTheVoid or rustdoc
This was referenced Oct 18, 2024
Open
Open
@fmease fmease mentioned this issue Oct 28, 2024
Merged
Kijewski added a commit to Kijewski/rinja that referenced this issue Nov 1, 2024
@Kijewski
"object safe" is now "dyn-compatible"
23f0e88 
The phrase was changed in
<rust-lang/rust#130852>.
@fmease fmease mentioned this issue Nov 20, 2024
Closed
@fmease
Copy link
Member

fmease commented Nov 23, 2024

Changes to the compiler & the libraries will be included in 1.83.
Changes to the Reference & rustdoc will be included in 1.84.

@fmease fmease mentioned this issue Nov 23, 2024
Merged
@fmease fmease added the A-dyn-compatibility Area: Dyn compatibility (formerly: object safety) label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmease fmease

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-dyn-compatibility Area: Dyn compatibility (formerly: object safety) C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@traviscross @fmease