improve incompatible option detection for ci-llvm #129153
Labels
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Comments
onur-ozkan
added
C-enhancement
rustbot
added
the
needs-triage
onur-ozkan
removed
the
needs-triage
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Sep 8, 2024
…-llvm, r=Kobzol detect incompatible CI LLVM options more precisely Previously, the logic here was simply checking whether the option was set in `config.toml`. This approach was not manageable in our CI runners as we set so many options in config.toml. In reality, those values are not incompatible since they are usually the same value used to generate the CI llvm. Now, the new logic compares the configuration values with the values used to generate the CI llvm, so we get more precise results and make the process more manageable. Fixes rust-lang#129153
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Sep 8, 2024
…-llvm, r=Kobzol detect incompatible CI LLVM options more precisely Previously, the logic here was simply checking whether the option was set in `config.toml`. This approach was not manageable in our CI runners as we set so many options in config.toml. In reality, those values are not incompatible since they are usually the same value used to generate the CI llvm. Now, the new logic compares the configuration values with the values used to generate the CI llvm, so we get more precise results and make the process more manageable. Fixes rust-lang#129153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since #128822, CI builders provide their configuration in the
builder-configfile, which can be used to more precisely detect incompatible ci-llvm options (similar to how it's done for rustc options in #129052). This helps to prevent incorrect assumptions of CI builders on a used llvm option which was also used while building ci-llvm artifact.The text was updated successfully, but these errors were encountered: