Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for XOP target feature #127208

Open
1 of 3 tasks
sayantn opened this issue Jul 1, 2024 · 2 comments
Open
1 of 3 tasks

Tracking Issue for XOP target feature #127208

sayantn opened this issue Jul 1, 2024 · 2 comments
Labels
A-SIMD Area: SIMD (Single Instruction Multiple Data) A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. O-x86_32 Target: x86 processors, 32 bit (like i686-*) O-x86_64 Target: x86-64 processors (like x86_64-*)

Comments

@sayantn
Copy link
Contributor

sayantn commented Jul 1, 2024 •
edited
Loading

The feature gate for this issue is #[feature(xop_target_feature)].

This tracks the integration of AMD's XOP instruction set into Rust.

Steps

  • Adding the xop target feature to Rustc and its runtime detection in stdarch
  • Final Comment Period (FCP)
  • Stabilization PR

Public API

The xop target-feature and its runtime detection

Implementation History
@sayantn sayantn added the C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. label Jul 1, 2024
@rustbot rustbot added A-SIMD Area: SIMD (Single Instruction Multiple Data) A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. O-x86_32 Target: x86 processors, 32 bit (like i686-*) O-x86_64 Target: x86-64 processors (like x86_64-*) labels Jul 1, 2024
This was referenced Jul 1, 2024
Merged
Merged
@VorpalBlade
Copy link

VorpalBlade commented Jul 1, 2024 •
edited
Loading

What is the point in supporting this? Apparently it was only ever supported on Buldozer (and other derived follows up like Piledriver etc), and was removed on Zen and later. So it seems largely like a historic curiosity of little use to anyone, with similar relevance as 3DNow.

@sayantn
Copy link
Contributor Author

sayantn commented Jul 1, 2024

That is true. I just saw that it was a major x86 target feature left unimplemented, so decided to start a pr. Also, a small addition like this shouldn't hurt.

workingjubilee added a commit to workingjubilee/rustc that referenced this issue Jul 12, 2024
@workingjubilee
Rollup merge of rust-lang#127209 - sayantn:xop, r=Amanieu
a6a7129 
Added the `xop` target-feature and the `xop_target_feature` feature gate

This is an effort towards rust-lang#127208. This adds the `xop` target feature gated by `xop_target_feature`.
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jul 13, 2024
@rust-timer
Unrolled build for rust-lang#127209
49b0115 
Rollup merge of rust-lang#127209 - sayantn:xop, r=Amanieu

Added the `xop` target-feature and the `xop_target_feature` feature gate

This is an effort towards rust-lang#127208. This adds the `xop` target feature gated by `xop_target_feature`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-SIMD Area: SIMD (Single Instruction Multiple Data) A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. O-x86_32 Target: x86 processors, 32 bit (like i686-*) O-x86_64 Target: x86-64 processors (like x86_64-*)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@VorpalBlade @rustbot @sayantn