-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std::os::fd module missing on Hermit #126198
Comments
rustbot
added
the
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
label
Jun 9, 2024
@rustbot label -needs-triage +O-hermit +A-cross +T-libs |
rustbot
added
A-cross
Area: Cross compilation
O-hermit
Operating System: Hermit
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
and removed
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
labels
Jun 9, 2024
Thomasdezeeuw
added a commit
to tokio-rs/mio
that referenced
this issue
Jun 9, 2024
For some reason the `std::os::fd` module is not available on Hermit. It seems like an oversight and I've opened rust-lang/rust#126198 to track a fix.
This was referenced Jun 9, 2024
@Thomasdezeeuw I agree, the |
Thomasdezeeuw
added a commit
to tokio-rs/mio
that referenced
this issue
Jun 14, 2024
For some reason the `std::os::fd` module is not available on Hermit. It seems like an oversight and I've opened rust-lang/rust#126198 to track a fix.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jun 17, 2024
Rollup merge of rust-lang#126346 - hermit-os:fd, r=Amanieu export std::os::fd module on HermitOS The HermitOS' IO interface is similiar to Unix. Consequently, this PR synchronize the FD implementation between both. closes rust-lang#126198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I tried this code:
With
--target x86_64-unknown-hermit
.I expected to see this happen: code to compile
Instead, this happened: failed to compile with
Looking at the relevant code:
rust/library/std/src/os/mod.rs
Lines 163 to 164 in 212841e
It seems
hermit
is imply missed from thecfg
. Inside of thefd
module there is already code for hermit:rust/library/std/src/os/fd/raw.rs
Lines 18 to 29 in 212841e
I think this is just an oversight, but I since I don't develop for Hermit I'm not sure. (I hit this while updating Mio)
/cc @stlankes
Meta
rustc --version --verbose
:The text was updated successfully, but these errors were encountered: