Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message for out of date dependencies? #12601

Closed
larsbergstrom opened this issue Feb 27, 2014 · 2 comments · Fixed by #12533
Closed

Better error message for out of date dependencies? #12601

larsbergstrom opened this issue Feb 27, 2014 · 2 comments · Fixed by #12533

Comments

@larsbergstrom
Copy link
Contributor

Right now, if you have a chain of dependencies (e.g. A depends on B depends on C) and rebuild C without rebuilding B, when you rebuild A, you will get an error like:

task 'rustc' failed at 'lookup_item: id not found: NUMBER at servo/src/compiler/rust/src/librustc/metadata/decoder.rs:92
Internal Compiler Error

If this is the only case where that error message occurs, it would be nice if it said something like "rebuild B", where possible.
@metajack
Copy link
Contributor

I think this is what #12533 attempts to fix. See also #10207

This may be a dupe of those.

@alexcrichton
Copy link
Member

Yes, #12533 will close this (putting this in the PR description)

@alexcrichton alexcrichton mentioned this issue Feb 27, 2014
Merged
@bors bors closed this as completed in 58ea029 Feb 28, 2014
@dckc dckc mentioned this issue Apr 6, 2014
Closed
@huonw huonw mentioned this issue Aug 4, 2014
Closed
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
@bors
Auto merge of rust-lang#12605 - erhuve:fix/determine-doc-link-type-at…
434e718 
…-start, r=erhuve

fix: doc_links link type - Determine link type at start (fixes rust-lang#12601)

fixes rust-lang#12601
Looked like autolink/inline mismatch happened because end_link_type was parsed from the Text/Code events.
I changed it to be determined from the Start event, which should hopefully remain accurate while staying true to the cases where link type may need to be changed, according to the comment
```
// normally link's type is determined by the type of link tag in the end event,
// however in some cases we want to change the link type, for example,
// `Shortcut` type doesn't make sense for url links
```
Hopefully this is the desired behavior?
![Untitled](https://user-images.githubusercontent.com/59463268/174696581-3b1140a5-cdf0-4eda-9a11-ec648e4e7d21.gif)
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 4, 2024
@bors
Auto merge of rust-lang#12601 - Alexendoo:box-default-style, r=llogiq
cb87a57 
Move `box_default` to style, do not suggest turbofishes

`Box::default()` [had its `#[rustc_box]` attribute removed](https://github.com/rust-lang/rust/pull/108476/files#r1120930164) in 1.69 so is no longer a perf related lint

The lint is moved to style but no longer produces suggestions containing turbofishes, as they're often longer/more annoying to type

changelog: [`box_default`]: Move to style

r? `@llogiq`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustc: Introduce Strict Version Hashes alexcrichton/rust
3 participants
@metajack @alexcrichton @larsbergstrom