Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for perma-unstable wasm-c-abi flag #122532

Open
1 of 2 tasks
daxpedda opened this issue Mar 15, 2024 · 2 comments · May be fixed by #133952
Open
1 of 2 tasks

Tracking Issue for perma-unstable wasm-c-abi flag #122532

daxpedda opened this issue Mar 15, 2024 · 2 comments · May be fixed by #133952
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC

Comments

@daxpedda
Copy link
Contributor

daxpedda commented Mar 15, 2024 •
edited by workingjubilee
Loading

This is a tracking issue for the MCP "perma-unstable wasm-c-abi flag" (rust-lang/compiler-team#703).

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Implementation history

Related issues
@daxpedda daxpedda added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Mar 15, 2024
@daxpedda daxpedda mentioned this issue Mar 15, 2024
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Apr 18, 2024
@GuillaumeGomez
Rollup merge of rust-lang#117919 - daxpedda:wasm-c-abi, r=wesleywiser
b61ff8c 
Introduce perma-unstable `wasm-c-abi` flag

Now that `wasm-bindgen` v0.2.88 supports the spec-compliant C ABI, the idea is to switch to that in a future version of Rust. In the meantime it would be good to let people test and play around with it.

This PR introduces a new perma-unstable `-Zwasm-c-abi` compiler flag, which switches to the new spec-compliant C ABI when targeting `wasm32-unknown-unknown`.

Alternatively, we could also stabilize this and then deprecate it when we switch. I will leave this to the Rust maintainers to decide.

This is a companion PR to rust-lang#117918, but they could be merged independently.
MCP: rust-lang/compiler-team#703
Tracking issue: rust-lang#122532
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Apr 18, 2024
@GuillaumeGomez
Rollup merge of rust-lang#117919 - daxpedda:wasm-c-abi, r=wesleywiser
44a6adc 
Introduce perma-unstable `wasm-c-abi` flag

Now that `wasm-bindgen` v0.2.88 supports the spec-compliant C ABI, the idea is to switch to that in a future version of Rust. In the meantime it would be good to let people test and play around with it.

This PR introduces a new perma-unstable `-Zwasm-c-abi` compiler flag, which switches to the new spec-compliant C ABI when targeting `wasm32-unknown-unknown`.

Alternatively, we could also stabilize this and then deprecate it when we switch. I will leave this to the Rust maintainers to decide.

This is a companion PR to rust-lang#117918, but they could be merged independently.
MCP: rust-lang/compiler-team#703
Tracking issue: rust-lang#122532
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Apr 18, 2024
@workingjubilee
Rollup merge of rust-lang#117919 - daxpedda:wasm-c-abi, r=wesleywiser
367fb06 
Introduce perma-unstable `wasm-c-abi` flag

Now that `wasm-bindgen` v0.2.88 supports the spec-compliant C ABI, the idea is to switch to that in a future version of Rust. In the meantime it would be good to let people test and play around with it.

This PR introduces a new perma-unstable `-Zwasm-c-abi` compiler flag, which switches to the new spec-compliant C ABI when targeting `wasm32-unknown-unknown`.

Alternatively, we could also stabilize this and then deprecate it when we switch. I will leave this to the Rust maintainers to decide.

This is a companion PR to rust-lang#117918, but they could be merged independently.
MCP: rust-lang/compiler-team#703
Tracking issue: rust-lang#122532
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Apr 18, 2024
@workingjubilee
Rollup merge of rust-lang#117919 - daxpedda:wasm-c-abi, r=wesleywiser
2fac1ae 
Introduce perma-unstable `wasm-c-abi` flag

Now that `wasm-bindgen` v0.2.88 supports the spec-compliant C ABI, the idea is to switch to that in a future version of Rust. In the meantime it would be good to let people test and play around with it.

This PR introduces a new perma-unstable `-Zwasm-c-abi` compiler flag, which switches to the new spec-compliant C ABI when targeting `wasm32-unknown-unknown`.

Alternatively, we could also stabilize this and then deprecate it when we switch. I will leave this to the Rust maintainers to decide.

This is a companion PR to rust-lang#117918, but they could be merged independently.
MCP: rust-lang/compiler-team#703
Tracking issue: rust-lang#122532
bors added a commit to rust-lang-ci/rust that referenced this issue Apr 19, 2024
@bors
Auto merge of rust-lang#117919 - daxpedda:wasm-c-abi, r=wesleywiser
13e63f7 
Introduce perma-unstable `wasm-c-abi` flag

Now that `wasm-bindgen` v0.2.88 supports the spec-compliant C ABI, the idea is to switch to that in a future version of Rust. In the meantime it would be good to let people test and play around with it.

This PR introduces a new perma-unstable `-Zwasm-c-abi` compiler flag, which switches to the new spec-compliant C ABI when targeting `wasm32-unknown-unknown`.

Alternatively, we could also stabilize this and then deprecate it when we switch. I will leave this to the Rust maintainers to decide.

This is a companion PR to rust-lang#117918, but they could be merged independently.
MCP: rust-lang/compiler-team#703
Tracking issue: rust-lang#122532
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Apr 20, 2024
@bors
Auto merge of #117919 - daxpedda:wasm-c-abi, r=wesleywiser
c79234c 
Introduce perma-unstable `wasm-c-abi` flag

Now that `wasm-bindgen` v0.2.88 supports the spec-compliant C ABI, the idea is to switch to that in a future version of Rust. In the meantime it would be good to let people test and play around with it.

This PR introduces a new perma-unstable `-Zwasm-c-abi` compiler flag, which switches to the new spec-compliant C ABI when targeting `wasm32-unknown-unknown`.

Alternatively, we could also stabilize this and then deprecate it when we switch. I will leave this to the Rust maintainers to decide.

This is a companion PR to #117918, but they could be merged independently.
MCP: rust-lang/compiler-team#703
Tracking issue: rust-lang/rust#122532
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this issue Apr 20, 2024
@bors
Auto merge of #117919 - daxpedda:wasm-c-abi, r=wesleywiser
4cc5eb0 
Introduce perma-unstable `wasm-c-abi` flag

Now that `wasm-bindgen` v0.2.88 supports the spec-compliant C ABI, the idea is to switch to that in a future version of Rust. In the meantime it would be good to let people test and play around with it.

This PR introduces a new perma-unstable `-Zwasm-c-abi` compiler flag, which switches to the new spec-compliant C ABI when targeting `wasm32-unknown-unknown`.

Alternatively, we could also stabilize this and then deprecate it when we switch. I will leave this to the Rust maintainers to decide.

This is a companion PR to #117918, but they could be merged independently.
MCP: rust-lang/compiler-team#703
Tracking issue: rust-lang/rust#122532
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this issue Apr 27, 2024
@bors
Auto merge of #117919 - daxpedda:wasm-c-abi, r=wesleywiser
7c78636 
Introduce perma-unstable `wasm-c-abi` flag

Now that `wasm-bindgen` v0.2.88 supports the spec-compliant C ABI, the idea is to switch to that in a future version of Rust. In the meantime it would be good to let people test and play around with it.

This PR introduces a new perma-unstable `-Zwasm-c-abi` compiler flag, which switches to the new spec-compliant C ABI when targeting `wasm32-unknown-unknown`.

Alternatively, we could also stabilize this and then deprecate it when we switch. I will leave this to the Rust maintainers to decide.

This is a companion PR to #117918, but they could be merged independently.
MCP: rust-lang/compiler-team#703
Tracking issue: rust-lang/rust#122532
GuillaumeGomez pushed a commit to GuillaumeGomez/rustc_codegen_gcc that referenced this issue May 21, 2024
@bors
Auto merge of #117919 - daxpedda:wasm-c-abi, r=wesleywiser
0f17e5a 
Introduce perma-unstable `wasm-c-abi` flag

Now that `wasm-bindgen` v0.2.88 supports the spec-compliant C ABI, the idea is to switch to that in a future version of Rust. In the meantime it would be good to let people test and play around with it.

This PR introduces a new perma-unstable `-Zwasm-c-abi` compiler flag, which switches to the new spec-compliant C ABI when targeting `wasm32-unknown-unknown`.

Alternatively, we could also stabilize this and then deprecate it when we switch. I will leave this to the Rust maintainers to decide.

This is a companion PR to #117918, but they could be merged independently.
MCP: rust-lang/compiler-team#703
Tracking issue: rust-lang/rust#122532
This was referenced Aug 24, 2024
Open
Open
@nikic nikic mentioned this issue Aug 24, 2024
Closed
This was referenced Aug 24, 2024
Merged
Merged
Merged
@workingjubilee
Copy link
Member

Since 1.78 a future-compat-warning for using too-old versions of wasm-bindgen has been in place, and now 75% of the ecosystem's downloads of crates are wasm-bindgen 0.2.89 or higher. I have opened #129534 as a discussion point for whether we should move the warning to a deny.

This was referenced Aug 25, 2024
Merged
Merged
Merged
newpavlov pushed a commit to rust-random/getrandom that referenced this issue Aug 26, 2024
@workingjubilee
wasm: Depend on wasm-bindgen 0.2.89 or higher (#497)
aa13fa5 
wasm-bindgen 0.2.62 is not compatible with a wasm ABI change that rustc
wishes to enable by default for wasm32-unknown-unknown, currently gated
behind passing the -Zwasm-c-abi flag to rustc.

wasm-bindgen 0.2.89 should exhibit seamless behavior before and after
the ABI change to match the C ABI, so depend on that.

For more information, see
- rust-lang/rust#115666
- rust-lang/rust#117918
- rust-lang/rust#122532
@bjorn3 bjorn3 mentioned this issue Dec 6, 2024
Open
@lcnr

This comment has been minimized.

Sign in to view
@bjorn3 bjorn3 linked a pull request Dec 6, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove wasm legacy abi bjorn3/rust
3 participants
@daxpedda @lcnr @workingjubilee