Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crate name not well rendered when it is to long #120471

Closed
wiiznokes opened this issue Jan 28, 2024 · 2 comments · Fixed by #120526
Closed

Crate name not well rendered when it is to long #120471

wiiznokes opened this issue Jan 28, 2024 · 2 comments · Fixed by #120526
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@wiiznokes
Copy link

On mobile using both firefox and Brave.

Screenshot_20240128-185816_Brave - Nightly.png
@wiiznokes wiiznokes changed the title Crate name not well rendered when the it is to long Crate name not well rendered when it is to long Jan 28, 2024
@Nemo157
Copy link
Member

Nemo157 commented Jan 29, 2024

This is presumably a rustdoc issue, unless our css somehow affects it, but I doubt it.

@Nemo157 Nemo157 transferred this issue from rust-lang/docs.rs Jan 29, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 29, 2024
@Nemo157 Nemo157 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Jan 29, 2024
@saethlin saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 30, 2024
@fmease fmease mentioned this issue Jan 30, 2024
Merged
@GuillaumeGomez
Copy link
Member

Taking a look.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jan 31, 2024
@GuillaumeGomez
Add regression test for rust-lang#120471 to ensure that long crate na…
242add7 
…me are handled as expected on mobile
@GuillaumeGomez GuillaumeGomez mentioned this issue Jan 31, 2024
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jan 31, 2024
@GuillaumeGomez
Add regression test for rust-lang#120471 to ensure that long crate na…
de6163f 
…me are handled as expected on mobile
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jan 31, 2024
@GuillaumeGomez
Add regression test for rust-lang#120471 to ensure that long crate na…
5d29f5a 
…me are handled as expected on mobile
CKingX added a commit to CKingX/rust that referenced this issue Feb 18, 2024
@CKingX
Rollup merge of rust-lang#120526 - GuillaumeGomez:mobile-long-crate-n…
12af8a9 
…ame, r=notriddle

rustdoc: Correctly handle long crate names on mobile

Fixes rust-lang#120471.

It now renders like this:

![image](https://github.com/rust-lang/rust/assets/3050060/065b4b8b-ba55-4163-a928-8d7bf735c111)

r? ``@notriddle``
@bors bors closed this as completed in fb5982f Feb 18, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Feb 18, 2024
@rust-timer
Unrolled build for rust-lang#120526
d6016aa 
Rollup merge of rust-lang#120526 - GuillaumeGomez:mobile-long-crate-name, r=notriddle

rustdoc: Correctly handle long crate names on mobile

Fixes rust-lang#120471.

It now renders like this:

![image](https://github.com/rust-lang/rust/assets/3050060/065b4b8b-ba55-4163-a928-8d7bf735c111)

r? `@notriddle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: Correctly handle long crate names on mobile GuillaumeGomez/rust
5 participants
@Nemo157 @GuillaumeGomez @saethlin @rustbot @wiiznokes