Remove rustpkg #11859
Labels
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Comments
|
I'll give this a shot |
|
@salemtalha ok! |
|
Wow. So this is really already decided... I have to say I'm pissed. |
|
@brson Question, when I remove the files mentioned in the issue the build process obviously fails, should I make a commit just with those removals and then fix the build process in a separate commit? |
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Dec 1, 2023
[`missing_asserts_for_indexing`]: work with bodies instead of blocks separately Fixes rust-lang#11856 Before this change, this lint would check blocks independently of each other, which means that it misses `assert!()`s from parent blocks. ```rs // check_block assert!(x.len() > 1); { // check_block // no assert here let _ = x[0] + x[1]; } ``` This PR changes it to work with bodies rather than individual blocks. That means that a function will be checked in one go and we can remember if an `assert!` occurred anywhere. Eventually it would be nice to have a more control flow-aware analysis, possibly by rewriting it as a MIR lint, but that's more complicated and I wanted this fixed first. changelog: [`missing_asserts_for_indexing`]: accept `assert!`s from parent blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
My ml thread here: https://mail.mozilla.org/pipermail/rust-dev/2014-January/008224.html
It's a shame so many people spent so much energy both creating it and trying to use it but, but let's get it over with.
Remove rustpkg, its man page, its manual, and the packaging guide.
The text was updated successfully, but these errors were encountered: