Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for ARM CRC32 intrinsics #117215

Closed
3 tasks
Amanieu opened this issue Oct 26, 2023 · 7 comments
Closed
3 tasks

Tracking Issue for ARM CRC32 intrinsics #117215

Amanieu opened this issue Oct 26, 2023 · 7 comments
Labels
A-SIMD Area: SIMD (Single Instruction Multiple Data) C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. O-AArch64 Armv8-A or later processors in AArch64 mode O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@Amanieu
Copy link
Member

Amanieu commented Oct 26, 2023

Feature gate: #![feature(stdarch_arm_crc32)]

This is a tracking issue CRC32 intrinsics on ARM and AArch64.

Public API

// core::arch::{arm,aarch64}

pub unsafe fn __crc32b(crc: u32, data: u8) -> u32;
pub unsafe fn __crc32cb(crc: u32, data: u8) -> u32;
pub unsafe fn __crc32h(crc: u32, data: u16) -> u32;
pub unsafe fn __crc32ch(crc: u32, data: u16) -> u32;
pub unsafe fn __crc32w(crc: u32, data: u32) -> u32;
pub unsafe fn __crc32cw(crc: u32, data: u32) -> u32;

// core::arch::aarch64

pub unsafe fn __crc32d(crc: u32, data: u64) -> u32;
pub unsafe fn __crc32cd(crc: u32, data: u64) -> u32;

Steps / History

  • Implementation: #...
  • Final comment period (FCP)1
  • Stabilization PR

Unresolved Questions

  • None yet.

Footnotes

  1. https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html

@Amanieu Amanieu added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. labels Oct 26, 2023
@Jules-Bertholet
Copy link
Contributor

@rustbot label o-aarch64 o-arm a-simd

@rustbot rustbot added A-SIMD Area: SIMD (Single Instruction Multiple Data) O-AArch64 Armv8-A or later processors in AArch64 mode O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state labels Oct 26, 2023
@Amanieu
Copy link
Member Author

Amanieu commented Feb 19, 2024

These intrinsics are documented as part of the ARM C language extensions.

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Feb 19, 2024

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Feb 19, 2024
@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Feb 20, 2024
@rfcbot
Copy link

rfcbot commented Feb 20, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Mar 1, 2024
@rfcbot
Copy link

rfcbot commented Mar 1, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@tgross35
Copy link
Contributor

I was thinking this could be closed since most of these are now stable, but __crc32d __crc32cd don't show up in core::arch::aarch64 for some reason.

@Amanieu
Copy link
Member Author

Amanieu commented Sep 30, 2024

Yes, the 32-bit intrinsics are tracked separately in #125085.

The docs issue is fixed by rust-lang/stdarch#1653.

@Amanieu Amanieu closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-SIMD Area: SIMD (Single Instruction Multiple Data) C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. O-AArch64 Armv8-A or later processors in AArch64 mode O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants