Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird <const host: bool = true> generics popping in beta docs #116629

Closed
a1phyr opened this issue Oct 11, 2023 · 2 comments
Closed

Weird <const host: bool = true> generics popping in beta docs #116629

a1phyr opened this issue Oct 11, 2023 · 2 comments
Assignees
@oli-obk @GuillaumeGomez
Labels
C-bug Category: This is a bug. F-effects `#![feature(effects)]` T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@a1phyr
Copy link
Contributor

a1phyr commented Oct 11, 2023

Examples include:

This is probably related to the recent addition of #[rustc_host].

image
@a1phyr a1phyr added the C-bug Category: This is a bug. label Oct 11, 2023
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 11, 2023
@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Oct 11, 2023
@GuillaumeGomez
Copy link
Member

Thanks for opening this issue! I'll take a look as soon as I can.

@fmease fmease added the F-effects `#![feature(effects)]` label Oct 11, 2023
@oli-obk oli-obk mentioned this issue Oct 12, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 13, 2023
@bors
Auto merge of rust-lang#116670 - oli-obk:host_docs, r=fmease
193e8a1 
Hide host effect params from docs

addresses (only on nightly, needs backport) rust-lang#116629

r? `@compiler-errors`

cc `@GuillaumeGomez` `@fee1-dead`
@a1phyr
Copy link
Contributor Author

a1phyr commented Oct 23, 2023

Fixed by #116670 and #116856

@a1phyr a1phyr closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oli-obk oli-obk

@GuillaumeGomez GuillaumeGomez

Labels
C-bug Category: This is a bug. F-effects `#![feature(effects)]` T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@oli-obk @GuillaumeGomez @fmease @a1phyr @rustbot