Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICE: assertion failed: !hidden_types.has_erased_regions() #116306

Closed
saethlin opened this issue Oct 1, 2023 · 3 comments
Closed

ICE: assertion failed: !hidden_types.has_erased_regions() #116306

saethlin opened this issue Oct 1, 2023 · 3 comments
Labels
C-bug Category: This is a bug. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ requires-debug-assertions This issue requires a build of rustc or tooling with debug-assertions in some way T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue.

Comments

@saethlin
Copy link
Member

saethlin commented Oct 1, 2023

I might be able to git bisect this tomorrow, unfortunately cargo-bisect-rustc can't help because this is a debug assertion.

cargo +stage1 install cargo-nextest --force

Starts at least on this commit:

ca62d2c445628587660ae48013f460b08b1f5552

Error output

thread 'rustc' panicked at compiler/rustc_trait_selection/src/traits/select/mod.rs:3119:9:
assertion failed: !hidden_types.has_erased_regions()

rustc-ice-2023-10-01T04:39:24.992139512Z-887849.txt
@saethlin saethlin added I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. requires-debug-assertions This issue requires a build of rustc or tooling with debug-assertions in some way labels Oct 1, 2023
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 1, 2023
@lqd
Copy link
Member

lqd commented Oct 1, 2023 •
edited
Loading

unfortunately cargo-bisect-rustc can't help because this is a debug assertion

I don't know about you, but I'm not sure we're getting everything we'd want out of the alt builds. I rarely hear about them, and especially not when they could have helped, like here: maybe enough time has passed by now to say debug assertions should also be turned on in the alt builds?

Anyway, I believe cargo-nextest-0.9.59 started triggering this assert in release mode with 286502c from #107421.

@Noratrieb Noratrieb added T-types Relevant to the types team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Oct 3, 2023
@cjgillot cjgillot mentioned this issue Oct 5, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 5, 2023
@matthiaskrgr
Rollup merge of rust-lang#116452 - cjgillot:noassert-erased, r=oli-obk
656eff3 
Do not assert that hidden types don't have erased regions.

cc rust-lang#116306

`args` can have erased regions.
In the linked issue, this is reached by computing whether a large type is `Freeze` to compute its ABI.

I do not have a minimized test to include.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 5, 2023
@matthiaskrgr
Rollup merge of rust-lang#116452 - cjgillot:noassert-erased, r=oli-obk
76d0b79 
Do not assert that hidden types don't have erased regions.

cc rust-lang#116306

`args` can have erased regions.
In the linked issue, this is reached by computing whether a large type is `Freeze` to compute its ABI.

I do not have a minimized test to include.
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 5, 2023
@rust-timer
Unrolled build for rust-lang#116452
68a24ee 
Rollup merge of rust-lang#116452 - cjgillot:noassert-erased, r=oli-obk

Do not assert that hidden types don't have erased regions.

cc rust-lang#116306

`args` can have erased regions.
In the linked issue, this is reached by computing whether a large type is `Freeze` to compute its ABI.

I do not have a minimized test to include.
@lqd
Copy link
Member

lqd commented Oct 19, 2023

This should have been fixed by #116452, can this issue be closed?

@saethlin
Copy link
Member Author

Yes, can confirm it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ requires-debug-assertions This issue requires a build of rustc or tooling with debug-assertions in some way T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lqd @saethlin @rustbot @Noratrieb