-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an abstraction to std::io::process for dealing with error gracefully #10669
Comments
std::run has been removed and some of its functionalities have been moved to std::io::process (see #12380) Does this issue still apply? |
This does indeed, updating the title. |
The links in @cmr's post seem to be broken.
|
With IO reform, what is the state of this? |
With the new |
Update to a compiletest-rs version that requires `//@` for commands Requires Manishearth/compiletest-rs#261 to get published This PR is a smaller step towards rust-lang/rust-clippy#10426 changelog: Move to a version of compiletest-rs that allows us to require `//`@`` for test suite commands.
Add a test that checks for old style test headers Follow up to rust-lang#10669, we're pretty used to them so they're easy to slip through changelog: none
A very common pattern when dealing with subprocesses is, when they fail, to print out or log some diagnostics. Lots of code that uses
std::run
rolls their own version of this. This shouldn't live in the stdlib, I think. Ideally a really nice CLI library would live in the extra conglomerate. For now, developing it as a separate crate and then merging it into libextra temporarily would be good.Examples that this would ideally replace:
https://github.com/huonw/multibuilder/blob/master/git.rs#L36 (and bunch elsewhere in this file)
https://github.com/huonw/multibuilder/blob/master/git.rs#L108
alexcrichton@cff13ae#diff-88c3a4f09e02361c7490165aacee98dfR41
(I'm sure many more can be found in other codebases)
The text was updated successfully, but these errors were encountered: