-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider graduating std::unstable::{sync,atomics} to std::sync #10627
Comments
I think this is blocking on #9758 |
|
It's correct as-implemented but I'm not sure supporting unwrapping as it does it is a good idea. It seems like it would make a lot more sense to just use This is a lot simpler, and can use faster atomic ordering requirements: https://github.com/thestinger/rust-core/blob/master/core/arc.rs |
I also believe that UnsafeArc should not support unwrapping. |
And agree that these should not be in the unstable module (which should be dismantled in favor of attributes anyway). |
A lot of the stuff in sync though worries me - it's just misc stuff, and some of it is not appropriate for general use. LittleLock and Exclusive use native mutexes. |
LittleLock is not the right name for something we want to be part of the public API, and both it and Exclusive are conflated with condvars. |
I am currently doing this in a local branch, but it may take some time to land. |
I'm leaving everything related to a mutex in |
This has been done. |
Or at least done to the degree that it should be done at this time. |
…_types, r=xFrednet Test all types supported by [`collection_is_never_read`] changelog: none
The utilities provided inside of std::unstable::{sync,atomics} are quite useful for writing concurrent code. It would be nice to polish off these interfaces and move them outside of the unstable module.
The text was updated successfully, but these errors were encountered: