Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustpkg test runs tests of an external dependency if it's already been downloaded #10395

Closed
sfackler opened this issue Nov 10, 2013 · 3 comments

Comments

@sfackler
Copy link
Member

https://github.com/sfackler/rust-postgres depends on https://github.com/sfackler/rust-ssl. When I run tests via rustpkg, the following very weird thing happens:

> git clone ssh://git@github.com/sfackler/rust-postgres.git
...
> cd rust-postgres
> env TMPDIR=$HOME/tmp rustpkg test
WARNING: The Rust package manager is experimental and may be unstable
note: Installed package github.com/sfackler/rust-ssl-0.1 to /home/sfackler/test/src/rust-postgres/.rust
note: Installed package github.com/sfackler/rust-ssl-0.1 to /home/sfackler/test/src/rust-postgres/.rust

running 73 tests
...
<rust-postgres tests omitted>
> touch test.rs
> env TMPDIR=$HOME/tmp rustpkg test
WARNING: The Rust package manager is experimental and may be unstable
note: Installed package github.com/sfackler/rust-ssl-0.1 to /home/sfackler/test/src/rust-postgres/.rust
note: Installed package github.com/sfackler/rust-ssl-0.1 to /home/sfackler/test/src/rust-postgres/.rust

running 10 tests
...
<rust-ssl tests omitted>
> rm -rf .rust
> env TMPDIR=$HOME/tmp rustpkg test
WARNING: The Rust package manager is experimental and may be unstable
note: Installed package github.com/sfackler/rust-ssl-0.1 to /home/sfackler/test/src/rust-postgres/.rust
note: Installed package github.com/sfackler/rust-ssl-0.1 to /home/sfackler/test/src/rust-postgres/.rust

running 73 tests
...
<rust-postgres tests omitted>

cc @catamorphism

@catamorphism
Copy link
Contributor

Looks valid. Offhand it wouldn't surprise me if rustpkg isn't caching the results of tests the way it caches build, and is re-running tests even if dependencies haven't changed.

@catamorphism
Copy link
Contributor

@sfackler also pointed out that it runs different tests the first time and the second time -- running the postgres tests the first time, and the ssl tests the second time. It doesn't seem like rustpkg test should test the dependencies all, actually, just the one crate that was provided as an (explicit or implicit) argument on the command line.

@alexcrichton
Copy link
Member

rustpkg has been removed

flip1995 pushed a commit to flip1995/rust that referenced this issue May 20, 2023
changelog: [`empty_line_after_doc_comments`]: add lint for checking
empty lines after rustdoc comments.

Fixes: rust-lang#10395
flip1995 pushed a commit to flip1995/rust that referenced this issue May 20, 2023
…archo

fix: warn on empty line outer AttrKind::DocComment

changelog: [`empty_line_after_doc_comments`]: add lint for checking empty lines after rustdoc comments.

Fixes: rust-lang#10395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants