rust 1.64 now uses fd-lock->rustix->flock() for bootstraping where flock() is not available on Solaris

[psumbera]

Seems that Rust now relies on fd-lock for bootstraping instead of using python code:

5a30316

Solaris doesn't support flock(). Insetad more modern fcntl() interface is used.

So even when I was able to make rustix compile on Solaris (without flock() support) it doesn't help since fd-lock requires flock().

Therefore I'm not able to compile Rust 1.64.0 on Solaris now.

[jyn514]

@psumbera adding a cfg(not(target_os = "solaris")) to that code seems reasonable, happy to take a PR.

[psumbera]

@psumbera adding a cfg(not(target_os = "solaris")) to that code seems reasonable, happy to take a PR.

But this way I still need to have buildable rustix for Solaris, right?

[jyn514]

Ah, I see. You can use those cfgs in Cargo.toml too I think. I'm surprised you get that error at compile time, is it trying to use something in libc that doesn't exist?

[psumbera]

Oh, I see that @gco has already fixed rustix Solaris build problems via bytecodealliance/rustix@d96706a .

[jyn514]

@psumbera does that mean we just have to update rustix to fix this error? Happy to take a PR for that :) cargo update -p rustix --manifest-path src/bootstrap/Cargo.toml should work.

[psumbera]

It's not just about updating rustix. It would still miss support for flock(). But we could try to emulate it via fcntl() then...

[jyn514]

Sure, seems reasonable :) I think you would need to modify fd-lock for that directly, though.

[jyn514]

You can also just disable locking for that target, we use it to prevent running in parallel by accident, but you can just be careful to only run one process of bootstrap at a time.

[zephaniahong]

@jyn514 Any help still needed here?

[jyn514]

@zephaniahong sure, but it will be hard to test your changes unless you have access to a Solaris machine ...

[zephaniahong]

I see! In that case, I'll leave it for someone else😅

[psumbera]

@jyn514 can you please have look at PR ##108607?

[albertlarsan68]

It is on my to-do list, the only thing I see left to do is create an issue to track which platforms have locking and which haven't.