ndk version up problem

[ksh8281]

i found diffrent thing in ndk r9b.
until ndk ~r9, function tgammaf is not defined at math.h.
so rust has fake tgammaf function in src/rt/rust_android_dummy.cpp
now, ndk r9b has tgammaf that is defined at sysroot/usr/include/math.h.(android-18)
so, it causes complie problem

/home/ksh8281/rust_android/rust/src/rt/rust_android_dummy.cpp: In function 'void tgammaf()':
/home/ksh8281/rust_android/rust/src/rt/rust_android_dummy.cpp:63:25: error: declaration of C function 'void tgammaf()' conflicts with
/home/ksh8281/rust_android/ndk/bin/../sysroot/usr/include/math.h:349:7: error: previous declaration 'float tgammaf(float)' here
make: *** [arm-linux-androideabi/rt/stage2/rust_android_dummy.o] Error 1

i tried to find prefer solution, but i cannot found best solution yet.(i think deleteing our tgammaf causes compatibility problem in order version of ndk)

[thestinger]

Is compatibility with old versions of the NDK useful?

[yichoi]

I think it is not useful.
If we want to maintain compatibility with old NDK, many variation of compile option should be guaranteed.
Let's make official NDK version which Rust basically require for android as r9b. then we can remove dummy function of tgammaf().

[thestinger]

+1 for removing it, we'll need the android buildbot updated though