Skip to content

Commit

Permalink
compiletest/rmake: cleanup comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jieyouxu committed Jul 19, 2024
1 parent 16c3ac1 commit ef2d0dd
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions src/tools/compiletest/src/runtest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3440,15 +3440,6 @@ impl<'test> TestCx<'test> {
// library.
// 2. We need to run the recipe binary.

// FIXME(jieyouxu): path examples
// source_root="/home/gh-jieyouxu/rust"
// src_root="/home/gh-jieyouxu/rust"
// build_root="/home/gh-jieyouxu/rust/build/aarch64-unknown-linux-gnu"
// self.config.build_base="/home/gh-jieyouxu/rust/build/aarch64-unknown-linux-gnu/test/run-make"
// support_lib_deps="/home/gh-jieyouxu/rust/build/aarch64-unknown-linux-gnu/stage1-tools/aarch64-unknown-linux-gnu/release/deps"
// support_lib_deps_deps="/home/gh-jieyouxu/rust/build/aarch64-unknown-linux-gnu/stage1-tools/release/deps"
// recipe_bin="/home/gh-jieyouxu/rust/build/aarch64-unknown-linux-gnu/test/run-make/a-b-a-linker-guard/a-b-a-linker-guard/rmake"

// So we assume the rust-lang/rust project setup looks like (our `.` is the top-level
// directory, irrelevant entries to our purposes omitted):
//
Expand Down Expand Up @@ -3607,8 +3598,6 @@ impl<'test> TestCx<'test> {
};
debug!(?recipe_bin);

// FIXME(jieyouxu): explain what the hecc we are doing here.
// FIXME(jieyouxu): audit these env vars. some of them only makes sense for make, not rustc!
let mut rustc = Command::new(&self.config.rustc_path);
rustc
// Specify output path
Expand Down Expand Up @@ -3694,8 +3683,6 @@ impl<'test> TestCx<'test> {
paths
};

// FIXME(jieyouxu): explain what the hecc we are doing here.
// FIXME(jieyouxu): audit these env vars. some of them only makes sense for make, not rustc!
// FIXME(jieyouxu): please rename `TARGET_RPATH_ENV`, `HOST_RPATH_DIR` and
// `TARGET_RPATH_DIR`, it is **extremely** confusing!
let mut cmd = Command::new(&recipe_bin);
Expand Down

0 comments on commit ef2d0dd

Please sign in to comment.