Skip to content

Commit

Permalink
Rollup merge of #94714 - ChrisDenton:win-close_read_wakes_up, r=Mark-…
Browse files Browse the repository at this point in the history
…Simulacrum

Enable `close_read_wakes_up` test on Windows

I wonder if we could/should try enabling this again? It was closed by #38867 due to #31657. I've tried running this test (along with other tests) on my machine a number of times and haven't seen this fail yet,

Caveat: the worst that can happen is this succeeds initially but then causes random hangs in CI. This is not a great failure mode and would be a reason not to do this.

If this does work out, closes #39006

r? `@Mark-Simulacrum`
  • Loading branch information
Dylan-DPC authored Mar 8, 2022
2 parents 568736b + 24ec0f2 commit ee8109d
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion library/std/src/net/tcp/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,6 @@ fn close_readwrite_smoke() {
}

#[test]
#[cfg(unix)] // test doesn't work on Windows, see #31657
fn close_read_wakes_up() {
each_ip(&mut |addr| {
let a = t!(TcpListener::bind(&addr));
Expand Down

0 comments on commit ee8109d

Please sign in to comment.