Skip to content

Commit

Permalink
Remove several FIXMEs
Browse files Browse the repository at this point in the history
  • Loading branch information
jooert committed May 4, 2015
1 parent 42123b7 commit e7d052e
Show file tree
Hide file tree
Showing 13 changed files with 16 additions and 41 deletions.
2 changes: 0 additions & 2 deletions src/test/run-pass/associated-types-impl-redirect.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
// for `ByRef`. The right answer was to consider the result ambiguous
// until more type information was available.

// ignore-pretty -- FIXME(#17362)

#![feature(lang_items, unboxed_closures)]
#![no_implicit_prelude]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
// for `ByRef`. The right answer was to consider the result ambiguous
// until more type information was available.

// ignore-pretty -- FIXME(#17362) pretty prints with `<<` which lexes wrong

#![feature(lang_items, unboxed_closures)]
#![no_implicit_prelude]

Expand Down
3 changes: 0 additions & 3 deletions src/test/run-pass/deriving-cmp-generic-struct-enum.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// no-pretty-expanded FIXME #15189


#[derive(PartialEq, Eq, PartialOrd, Ord)]
enum ES<T> {
ES1 { x: T },
Expand Down
3 changes: 0 additions & 3 deletions src/test/run-pass/deriving-cmp-generic-struct.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// no-pretty-expanded FIXME #15189


#[derive(PartialEq, Eq, PartialOrd, Ord)]
struct S<T> {
x: T,
Expand Down
3 changes: 0 additions & 3 deletions src/test/run-pass/deriving-cmp-generic-tuple-struct.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// no-pretty-expanded FIXME #15189


#[derive(PartialEq, Eq, PartialOrd, Ord)]
struct TS<T>(T,T);

Expand Down
4 changes: 1 addition & 3 deletions src/test/run-pass/deriving-self-lifetime-totalord-totaleq.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,9 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-test FIXME #11820: & is unreliable in deriving

use std::cmp::Ordering::{Less,Equal,Greater};

#[derive(Eq,Ord)]
#[derive(PartialEq, Eq, PartialOrd, Ord)]
struct A<'a> {
x: &'a isize
}
Expand Down
2 changes: 0 additions & 2 deletions src/test/run-pass/generic-recursive-tag.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-pretty FIXME(#14193)

#![allow(unknown_features)]
#![feature(box_syntax)]

Expand Down
2 changes: 0 additions & 2 deletions src/test/run-pass/issue-19081.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-pretty -- FIXME(#17362) pretty prints as `Hash<<Self as Hasher...` which fails to parse

pub trait Hasher {
type State;

Expand Down
1 change: 0 additions & 1 deletion src/test/run-pass/last-use-in-cap-clause.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ struct A { a: Box<isize> }
fn foo() -> Box<FnMut() -> isize + 'static> {
let k: Box<_> = box 22;
let _u = A {a: k.clone()};
// FIXME(#16640) suffix in `22` suffix shouldn't be necessary
let result = || 22;
// FIXME (#22405): Replace `Box::new` with `box` here when/if possible.
Box::new(result)
Expand Down
12 changes: 4 additions & 8 deletions src/test/run-pass/ufcs-polymorphic-paths.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ use std::default::Default;
use std::iter::FromIterator;
use std::ops::Add;
use std::option::IntoIter as OptionIter;
// FIXME the glob std::prelude::*; import of Vec is missing non-static inherent
// methods.
use std::vec::Vec;

pub struct XorShiftRng;
use XorShiftRng as DummyRng;
Expand Down Expand Up @@ -81,11 +78,10 @@ tests! {
Vec::map_in_place, fn(Vec<u8>, fn(u8) -> i8) -> Vec<i8>, (vec![b'f', b'o', b'o'], u8_as_i8);
Vec::map_in_place::<i8, fn(u8) -> i8>, fn(Vec<u8>, fn(u8) -> i8) -> Vec<i8>,
(vec![b'f', b'o', b'o'], u8_as_i8);
// FIXME these break with "type parameter might not appear here pointing at `<u8>`.
// Vec::<u8>::map_in_place: fn(Vec<u8>, fn(u8) -> i8) -> Vec<i8>
// , (vec![b'f', b'o', b'o'], u8_as_i8);
// Vec::<u8>::map_in_place::<i8, fn(u8) -> i8>: fn(Vec<u8>, fn(u8) -> i8) -> Vec<i8>
// , (vec![b'f', b'o', b'o'], u8_as_i8);
Vec::<u8>::map_in_place, fn(Vec<u8>, fn(u8) -> i8) -> Vec<i8>
, (vec![b'f', b'o', b'o'], u8_as_i8);
Vec::<u8>::map_in_place::<i8, fn(u8) -> i8>, fn(Vec<u8>, fn(u8) -> i8) -> Vec<i8>
, (vec![b'f', b'o', b'o'], u8_as_i8);

// Trait static methods.
bool::size, fn() -> usize, ();
Expand Down
3 changes: 0 additions & 3 deletions src/test/run-pass/unfold-cross-crate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// no-pretty-expanded FIXME #15189


#![feature(core)]

use std::iter::Unfold;
Expand Down
2 changes: 0 additions & 2 deletions src/test/run-pass/utf8.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
//
// no-pretty-expanded FIXME #15189

pub fn main() {
let yen: char = '¥'; // 0xa5
Expand Down
18 changes: 11 additions & 7 deletions src/test/run-pass/vec-fixed-length.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,22 @@

use std::mem::size_of;

pub fn main() {
#[cfg(not(target_pointer_width = "64"))]
fn test_big_vec() {}

#[cfg(target_pointer_width = "64")]
fn test_big_vec()
{
assert_eq!(size_of::<[u8; (1 << 32)]>(), (1 << 32));
}

fn main() {
let x: [isize; 4] = [1, 2, 3, 4];
assert_eq!(x[0], 1);
assert_eq!(x[1], 2);
assert_eq!(x[2], 3);
assert_eq!(x[3], 4);

assert_eq!(size_of::<[u8; 4]>(), 4);

// FIXME #10183
// FIXME #18069
//if cfg!(target_pointer_width = "64") {
// assert_eq!(size_of::<[u8; (1 << 32)]>(), (1 << 32));
//}
test_big_vec();
}

0 comments on commit e7d052e

Please sign in to comment.