Skip to content

Commit

Permalink
Make yield_in_scope_for_expr work with patterns. Fixes #47758
Browse files Browse the repository at this point in the history
  • Loading branch information
Zoxc committed Jan 29, 2018
1 parent ad058cf commit dd3fa07
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/librustc/middle/region.rs
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,9 @@ impl<'tcx> Visitor<'tcx> for ExprLocatorVisitor {

self.expr_and_pat_count += 1;

if pat.id == self.id {
self.result = Some(self.expr_and_pat_count);
}
}

fn visit_expr(&mut self, expr: &'tcx Expr) {
Expand Down
23 changes: 23 additions & 0 deletions src/test/ui/generator/pattern-borrow.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![feature(generators)]

enum Test { A(i32), B, }

fn main() { }

fn fun(test: Test) {
move || {
if let Test::A(ref _a) = test { //~ ERROR borrow may still be in use when generator yields
yield ();
}
};
}
10 changes: 10 additions & 0 deletions src/test/ui/generator/pattern-borrow.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
error[E0626]: borrow may still be in use when generator yields
--> $DIR/pattern-borrow.rs:19:24
|
19 | if let Test::A(ref _a) = test { //~ ERROR borrow may still be in use when generator yields
| ^^^^^^
20 | yield ();
| -------- possible yield occurs here

error: aborting due to previous error

0 comments on commit dd3fa07

Please sign in to comment.