Skip to content

Commit

Permalink
Refactor: Move the mutable parts out of LintStore. Fix #42007.
Browse files Browse the repository at this point in the history
* #42007 happens because the Session LintStore is emptied when linting.
* The Session LintStore is emptied because the checker (Early/LateContext)
  wants ownership.
* The checker wants ownership because it wants to mutate the pass objects
  and lint levels.

The ownership of the whole store is not essential, only the lint levels and
pass objects need to be owned. Therefore, these parts are extracted out of
the LintStore into a separate structure `LintSession`. The "check crates"
methods can operate on `&mut LintSession` instead of `&mut LintStore`.

This is a minor BREAKING CHANGE for lint writers since the `LintContext`
trait is changed: the `mut_lints` and `level_stack` methods are removed.
But no one outside of `librustc/lint/context.rs` is using these functions,
so it should be safe.
  • Loading branch information
kennytm committed May 17, 2017
1 parent 42e3732 commit b384b18
Show file tree
Hide file tree
Showing 3 changed files with 198 additions and 86 deletions.
Loading

0 comments on commit b384b18

Please sign in to comment.