-
Notifications
You must be signed in to change notification settings - Fork 13k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add check before suggest removing parens
- Loading branch information
Showing
3 changed files
with
64 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
enum Enum<T> { , SVariant { v: T }, UVariant } //~ ERROR expected identifier, found `,` | ||
|
||
macro_rules! is_variant { | ||
(TSVariant, ) => (!); | ||
(SVariant, ) => (!); | ||
(UVariant, $expr:expr) => (is_variant!(@check UVariant, {}, $expr)); | ||
(@check $variant:ident, $matcher:tt, $expr:expr) => ( | ||
assert!(if let Enum::$variant::<()> $matcher = $expr () else { false }, //~ ERROR this `if` expression | ||
); | ||
); | ||
} | ||
|
||
fn main() { | ||
is_variant!(UVariant, Enum::<()>::UVariant); //~ ERROR expected function | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
error: expected identifier, found `,` | ||
--> $DIR/issue-114701.rs:1:16 | ||
| | ||
LL | enum Enum<T> { , SVariant { v: T }, UVariant } | ||
| ^ | ||
| | | ||
| expected identifier | ||
| help: remove this comma | ||
|
||
error: this `if` expression is missing a block after the condition | ||
--> $DIR/issue-114701.rs:8:17 | ||
| | ||
LL | assert!(if let Enum::$variant::<()> $matcher = $expr () else { false }, | ||
| ^^ | ||
... | ||
LL | is_variant!(UVariant, Enum::<()>::UVariant); | ||
| ------------------------------------------- in this macro invocation | ||
| | ||
help: add a block here | ||
--> $DIR/issue-114701.rs:8:64 | ||
| | ||
LL | assert!(if let Enum::$variant::<()> $matcher = $expr () else { false }, | ||
| ^ | ||
... | ||
LL | is_variant!(UVariant, Enum::<()>::UVariant); | ||
| ------------------------------------------- in this macro invocation | ||
= note: this error originates in the macro `is_variant` (in Nightly builds, run with -Z macro-backtrace for more info) | ||
help: remove the `if` if you meant to write a `let...else` statement | ||
| | ||
LL - assert!(if let Enum::$variant::<()> $matcher = $expr () else { false }, | ||
LL + assert!(let Enum::$variant::<()> $matcher = $expr () else { false }, | ||
| | ||
|
||
error[E0618]: expected function, found `Enum<()>` | ||
--> $DIR/issue-114701.rs:14:27 | ||
| | ||
LL | enum Enum<T> { , SVariant { v: T }, UVariant } | ||
| -------- `Enum::UVariant` defined here | ||
... | ||
LL | assert!(if let Enum::$variant::<()> $matcher = $expr () else { false }, | ||
| -------- call expression requires function | ||
... | ||
LL | is_variant!(UVariant, Enum::<()>::UVariant); | ||
| ^^^^^^^^^^^^^^^^^^^^ | ||
|
||
error: aborting due to 3 previous errors | ||
|
||
For more information about this error, try `rustc --explain E0618`. |