Skip to content

Commit

Permalink
Update assists test fixtures
Browse files Browse the repository at this point in the history
  • Loading branch information
Veykril committed May 22, 2024
1 parent b29c755 commit b1830a5
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 29 deletions.
18 changes: 1 addition & 17 deletions src/tools/rust-analyzer/crates/hir/src/term_search/expr.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
//! Type tree for term search
use hir_def::find_path::PrefixKind;
use hir_expand::mod_path::ModPath;
use hir_ty::{
db::HirDatabase,
Expand All @@ -21,23 +20,8 @@ fn mod_item_path(
prefer_prelude: bool,
) -> Option<ModPath> {
let db = sema_scope.db;
// Account for locals shadowing items from module
let name_hit_count = def.name(db).map(|def_name| {
let mut name_hit_count = 0;
sema_scope.process_all_names(&mut |name, _| {
if name == def_name {
name_hit_count += 1;
}
});
name_hit_count
});

let m = sema_scope.module();
let prefix = match name_hit_count {
Some(0..=1) | None => PrefixKind::Plain,
Some(_) => PrefixKind::ByCrate,
};
m.find_use_path(db.upcast(), *def, prefix, prefer_no_std, prefer_prelude)
m.find_path(db.upcast(), *def, prefer_no_std, prefer_prelude)
}

/// Helper function to get path to `ModuleDef` as string
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1521,7 +1521,7 @@ mod foo {
}
"#,
r#"
use crate::foo::Bool;
use foo::Bool;
fn main() {
use foo::FOO;
Expand Down Expand Up @@ -1602,7 +1602,7 @@ pub mod bar {
"#,
r#"
//- /main.rs
use crate::foo::bar::Bool;
use foo::bar::Bool;
mod foo;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,7 @@ pub mod bar {
"#,
r#"
//- /main.rs
use crate::foo::bar::BarResult;
use foo::bar::BarResult;
mod foo;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -881,7 +881,7 @@ fn another_fn() {
r#"use my_mod::my_other_mod::MyField;
mod my_mod {
use self::my_other_mod::MyField;
use my_other_mod::MyField;
fn another_fn() {
let m = my_other_mod::MyEnum::MyField(MyField(1, 1));
Expand Down
18 changes: 11 additions & 7 deletions src/tools/rust-analyzer/crates/ide-db/src/imports/import_assets.rs
Original file line number Diff line number Diff line change
Expand Up @@ -637,13 +637,17 @@ fn get_mod_path(
prefer_no_std: bool,
prefer_prelude: bool,
) -> Option<ModPath> {
module_with_candidate.find_use_path(
db,
item_to_search,
prefixed.unwrap_or(PrefixKind::Plain),
prefer_no_std,
prefer_prelude,
)
if let Some(prefix_kind) = prefixed {
module_with_candidate.find_use_path(
db,
item_to_search,
prefix_kind,
prefer_no_std,
prefer_prelude,
)
} else {
module_with_candidate.find_path(db, item_to_search, prefer_no_std, prefer_prelude)
}
}

impl ImportCandidate {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,7 @@ fn main() {
);
}

// FIXME
#[test]
fn local_shadow_fn() {
check_fixes_unordered(
Expand All @@ -385,7 +386,7 @@ fn f() {
r#"
fn f() {
let f: i32 = 0;
crate::f()
f()
}"#,
],
);
Expand Down

0 comments on commit b1830a5

Please sign in to comment.