Skip to content

Commit

Permalink
auto merge of #18802 : bkoropoff/rust/issue-18769, r=luqmana
Browse files Browse the repository at this point in the history
Drill down the loan path for `McDeclared` references as well since it might lead to an upvar.  Closes #18769
  • Loading branch information
bors committed Nov 10, 2014
2 parents f187573 + c0a7d55 commit a30b72b
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/librustc/middle/borrowck/gather_loans/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -395,10 +395,10 @@ impl<'a, 'tcx> GatherLoanCtxt<'a, 'tcx> {
LpUpvar(ty::UpvarId{ var_id: local_id, closure_expr_id: _ }) => {
self.tcx().used_mut_nodes.borrow_mut().insert(local_id);
}
LpExtend(ref base, mc::McInherited, _) => {
LpExtend(ref base, mc::McInherited, _) |
LpExtend(ref base, mc::McDeclared, _) => {
self.mark_loan_path_as_mutated(&**base);
}
LpExtend(_, mc::McDeclared, _) |
LpExtend(_, mc::McImmutable, _) => {
// Nothing to do.
}
Expand Down
12 changes: 11 additions & 1 deletion src/test/run-pass/unboxed-closures-move-mutable.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
// Test that mutating a mutable upvar in a capture-by-value unboxed
// closure does not ice (issue #18238) and marks the upvar as used
// mutably so we do not get a spurious warning about it not needing to
// be declared mutable (issue #18336).
// be declared mutable (issue #18336 and #18769)

fn set(x: &mut uint) { *x = 42; }

fn main() {
{
Expand All @@ -25,4 +27,12 @@ fn main() {
let mut x = 0u;
move |:| x += 1;
}
{
let mut x = 0u;
move |&mut:| set(&mut x);
}
{
let mut x = 0u;
move |:| set(&mut x);
}
}

0 comments on commit a30b72b

Please sign in to comment.