Skip to content

Commit

Permalink
Rollup merge of #124036 - alexcrichton:wasm-use-default-visbility, r=…
Browse files Browse the repository at this point in the history
…jieyouxu

Remove `default_hidden_visibility: false` from wasm targets

To the best of my ability I believe that this is no longer necessary. I don't fully recall why this was first added but I believe it had to do with symbols all being exported by default and this was required to undo that. Regardless nowadays the default output of rustc seems suitable so it seems best to keep wasm in line with other targets.
  • Loading branch information
GuillaumeGomez authored Apr 16, 2024
2 parents c7b009f + f25668c commit a0ca118
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions compiler/rustc_target/src/spec/base/wasm.rs
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,6 @@ pub fn options() -> TargetOptions {
// threaded model which will legalize atomics to normal operations.
singlethread: true,

// no dynamic linking, no need for default visibility!
default_hidden_visibility: true,

// Symbol visibility takes care of this for the WebAssembly.
// Additionally the only known linker, LLD, doesn't support the script
// arguments just yet
Expand Down

0 comments on commit a0ca118

Please sign in to comment.