Skip to content

Commit

Permalink
Auto merge of #85344 - cbeuw:remap-across-cwd, r=michaelwoerister
Browse files Browse the repository at this point in the history
Correctly handle remapping from path containing the current directory with trailing paths

If we have a `auxiliary/lib.rs`, and we generate the metadata with `--remap-path-prefix $PWD/auxiliary=xyz`, the path to `$PWD/auxiliary/lib.rs` won't be correctly remapped in the metadata. This is because internally, path to the working directory itself and relative paths to files under the working directory are remapped separately (hence neither are affected since neither has `$PWD/auxiliary` as prefix), but the concatenation between the working directory and the relative path is not remapped. This PR fixes that.
  • Loading branch information
bors committed Aug 25, 2021
2 parents 9863bf5 + 7ed9f2e commit 958d788
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 5 deletions.
19 changes: 14 additions & 5 deletions compiler/rustc_metadata/src/rmeta/encoder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -509,11 +509,20 @@ impl<'a, 'tcx> EncodeContext<'a, 'tcx> {
let working_dir = &self.tcx.sess.opts.working_dir;
match working_dir {
RealFileName::LocalPath(absolute) => {
// If working_dir has not been remapped, then we emit a
// LocalPath variant as it's likely to be a valid path
RealFileName::LocalPath(
Path::new(absolute).join(path_to_file),
)
// Although neither working_dir or the file name were subject
// to path remapping, the concatenation between the two may
// be. Hence we need to do a remapping here.
let joined = Path::new(absolute).join(path_to_file);
let (joined, remapped) =
source_map.path_mapping().map_prefix(joined);
if remapped {
RealFileName::Remapped {
local_path: None,
virtual_name: joined,
}
} else {
RealFileName::LocalPath(joined)
}
}
RealFileName::Remapped { local_path: _, virtual_name } => {
// If working_dir has been remapped, then we emit
Expand Down
9 changes: 9 additions & 0 deletions src/test/run-make-fulldeps/remap-path-prefix/Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
-include ../tools.mk

# ignore-windows

# Checks if remapping works if the remap-from string contains path to the working directory plus more
all:
$(RUSTC) --remap-path-prefix $$PWD/auxiliary=/the/aux --crate-type=lib --emit=metadata auxiliary/lib.rs
grep "/the/aux/lib.rs" $(TMPDIR)/liblib.rmeta || exit 1
! grep "$$PWD/auxiliary" $(TMPDIR)/liblib.rmeta || exit 1
3 changes: 3 additions & 0 deletions src/test/run-make-fulldeps/remap-path-prefix/auxiliary/lib.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
pub fn lib() {
panic!("calm");
}

0 comments on commit 958d788

Please sign in to comment.