Skip to content

Commit

Permalink
Rollup merge of #122363 - Enselic:unix_sigpipe-str-list, r=oli-obk
Browse files Browse the repository at this point in the history
tests: Add ui/attributes/unix_sigpipe/unix_sigpipe-str-list.rs

Which is a variant of [`unix_sigpipe-list.rs`][1] but where a string is used instead of an identifier. This makes it more similar to the proper form `#[unix_sigpipe = "sig_dfl"]` and thus more likely to be written by users by mistake. Having a test for this case gives peace of mind.

Also rename the first test to be more in line with the terminology of [The Reference][2].

[1]: https://github.com/rust-lang/rust/blob/master/tests/ui/attributes/unix_sigpipe/unix_sigpipe-list.rs
[2]: https://doc.rust-lang.org/reference/attributes.html#meta-item-attribute-syntax

Tracking issue: #97889
  • Loading branch information
workingjubilee committed Mar 12, 2024
2 parents 1aef2fb + 98553ce commit 778c76c
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error: malformed `unix_sigpipe` attribute input
--> $DIR/unix_sigpipe-list.rs:3:1
--> $DIR/unix_sigpipe-ident-list.rs:3:1
|
LL | #[unix_sigpipe(sig_dfl)]
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: must be of the form: `#[unix_sigpipe = "inherit|sig_ign|sig_dfl"]`
Expand Down
4 changes: 4 additions & 0 deletions tests/ui/attributes/unix_sigpipe/unix_sigpipe-str-list.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#![feature(unix_sigpipe)]

#[unix_sigpipe("sig_dfl")] //~ error: malformed `unix_sigpipe` attribute input
fn main() {}
8 changes: 8 additions & 0 deletions tests/ui/attributes/unix_sigpipe/unix_sigpipe-str-list.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
error: malformed `unix_sigpipe` attribute input
--> $DIR/unix_sigpipe-str-list.rs:3:1
|
LL | #[unix_sigpipe("sig_dfl")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: must be of the form: `#[unix_sigpipe = "inherit|sig_ign|sig_dfl"]`

error: aborting due to 1 previous error

0 comments on commit 778c76c

Please sign in to comment.