Skip to content

Commit

Permalink
Enable f16 tests on loongarch
Browse files Browse the repository at this point in the history
Loongarch previously had a selection failure for `f16` math [1]. This
was fixed in [2], which Rust got with the update to LLVM19.

Enable it in `std/build.rs` so we start running tests.

[1]: llvm/llvm-project#93894
[2]: llvm/llvm-project#94456
  • Loading branch information
tgross35 committed Aug 22, 2024
1 parent a32d4a0 commit 737bfc0
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions library/std/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,6 @@ fn main() {
let has_reliable_f16 = match (target_arch.as_str(), target_os.as_str()) {
// We can always enable these in Miri as that is not affected by codegen bugs.
_ if is_miri => true,
// Selection failure until recent LLVM <https://github.com/llvm/llvm-project/issues/93894>
// FIXME(llvm19): can probably be removed at the version bump
("loongarch64", _) => false,
// Selection failure <https://github.com/llvm/llvm-project/issues/50374>
("s390x", _) => false,
// Unsupported <https://github.com/llvm/llvm-project/issues/94434>
Expand Down

0 comments on commit 737bfc0

Please sign in to comment.