-
Notifications
You must be signed in to change notification settings - Fork 12.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rollup merge of #131417 - GuillaumeGomez:mobile-methods-left-margin, …
…r=notriddle Fix methods alignment on mobile I realized that on mobile, the methods are not aligned the same depending if they have documentation or not: | before | after | |-|-| | ![Screenshot from 2024-10-08 20-40-22](https://github.com/user-attachments/assets/d31ba5e1-cf84-431f-9b2b-9962bc5a0365) | ![image](https://github.com/user-attachments/assets/ffde2161-bfcb-4462-8c5b-88538e61b366) | r? `@notriddle`
- Loading branch information
Showing
3 changed files
with
23 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// This test is to ensure that methods are correctly aligned on the left side. | ||
|
||
go-to: "file://" + |DOC_PATH| + "/test_docs/struct.Foo.html" | ||
|
||
// First we ensure that we have methods with and without documentation. | ||
assert: ".impl-items > details.method-toggle > summary > section.method" | ||
assert: ".impl-items > section.method" | ||
|
||
// Checking on desktop. | ||
set-window-size: (900, 600) | ||
wait-for-size: ("body", {"width": 900}) | ||
store-position: (".impl-items section.method", {"x": x}) | ||
assert-position: (".impl-items section.method", {"x": |x|}, ALL) | ||
|
||
// Checking on mobile. | ||
set-window-size: (600, 600) | ||
wait-for-size: ("body", {"width": 600}) | ||
store-position: (".impl-items section.method", {"x": x}) | ||
assert-position: (".impl-items section.method", {"x": |x|}, ALL) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters