-
Notifications
You must be signed in to change notification settings - Fork 13.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove note about iteration count in coerce
and replace it with a simple note suggesting returning a value. The type mismatch error was never due to how many times the loop iterates. It is more because of the peculiar structure of what the for loop desugars to. So the note talking about iteration count didn't make sense
- Loading branch information
Showing
14 changed files
with
450 additions
and
200 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule stdarch
updated
68 files
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| // Regression test for #122561 | ||
|
|
||
| fn for_infinite() -> bool { | ||
| for i in 0.. { | ||
| //~^ ERROR mismatched types | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| fn for_finite() -> String { | ||
| for i in 0..5 { | ||
| //~^ ERROR mismatched types | ||
| return String::from("test"); | ||
| } | ||
| } | ||
|
|
||
| fn for_never_type() -> ! { | ||
| for i in 0..0 { | ||
| //~^ ERROR mismatched types | ||
| } | ||
| } | ||
|
|
||
| // Entire function on a single line. | ||
| // Tests that we format the suggestion | ||
| // correctly in this case | ||
| fn for_single_line() -> bool { for i in 0.. { return false; } } | ||
| //~^ ERROR mismatched types | ||
|
|
||
| // Loop in an anon const in function args | ||
| // Tests that we: | ||
| // a. deal properly with this complex case | ||
| // b. format the suggestion correctly so | ||
| // that it's readable | ||
| fn for_in_arg(a: &[(); for x in 0..2 {}]) -> bool { | ||
| //~^ ERROR `for` is not allowed in a `const` | ||
| //~| ERROR mismatched types | ||
| true | ||
| } | ||
|
|
||
| fn while_true() -> bool { | ||
| while true { | ||
| //~^ ERROR mismatched types | ||
| //~| WARN denote infinite loops with `loop { ... }` [while_true] | ||
| return true; | ||
| } | ||
| } | ||
|
|
||
| fn while_false() -> bool { | ||
| while false { | ||
| //~^ ERROR mismatched types | ||
| return true; | ||
| } | ||
| } | ||
|
|
||
| fn while_true_never_type() -> ! { | ||
| while true { | ||
| //~^ ERROR mismatched types | ||
| //~| WARN denote infinite loops with `loop { ... }` [while_true] | ||
| } | ||
| } | ||
|
|
||
| // No type mismatch error in this case | ||
| fn loop_() -> bool { | ||
| loop { | ||
| return true; | ||
| } | ||
| } | ||
|
|
||
| const C: i32 = { | ||
| for i in 0.. { | ||
| //~^ ERROR `for` is not allowed in a `const` | ||
| //~| ERROR mismatched types | ||
| } | ||
| }; | ||
|
|
||
| fn main() { | ||
| let _ = [10; { | ||
| for i in 0..5 { | ||
| //~^ ERROR `for` is not allowed in a `const` | ||
| //~| ERROR mismatched types | ||
| } | ||
| }]; | ||
|
|
||
| let _ = [10; { | ||
| while false { | ||
| //~^ ERROR mismatched types | ||
| } | ||
| }]; | ||
|
|
||
|
|
||
| let _ = |a: &[(); for x in 0..2 {}]| {}; | ||
| //~^ ERROR `for` is not allowed in a `const` | ||
| //~| ERROR mismatched types | ||
| } |
Oops, something went wrong.