Delay the construction of early lint diag structs

Fixes a slew of perf regressions.
rust-lang · May 23, 2024 · 37bf2d2 · 37bf2d2
1 parent 9f67c50
commit 37bf2d2
Show file tree

Hide file tree

Showing 2 changed files with 156 additions and 231 deletions.
diff --git a/compiler/rustc_lint/src/context.rs b/compiler/rustc_lint/src/context.rs
@@ -539,7 +539,9 @@ impl EarlyContext<'_> {
         span: MultiSpan,
         diagnostic: BuiltinLintDiag,
     ) {
-        diagnostics::emit_buffered_lint(self, lint, span, diagnostic)
+        self.opt_span_lint(lint, Some(span), |diag| {
+            diagnostics::decorate_lint(self.sess(), diagnostic, diag);
+        });
     }
 }