Skip to content

Commit

Permalink
Add backquotes to have better looking rust code
Browse files Browse the repository at this point in the history
  • Loading branch information
GuillaumeGomez committed Apr 18, 2015
1 parent 49a94f2 commit 1d7d019
Showing 1 changed file with 21 additions and 3 deletions.
24 changes: 21 additions & 3 deletions src/librustc/diagnostics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,13 @@ the following is invalid as it requires the entire Option<String> to be moved
into a variable called `op_string` while simultaneously requiring the inner
String to be moved into a variable called `s`.
```
let x = Some("s".to_string());
match x {
op_string @ Some(s) => ...
None => ...
}
```
See also Error 303.
"##,
Expand All @@ -90,10 +92,12 @@ name is bound by move in a pattern, it should also be moved to wherever it is
referenced in the pattern guard code. Doing so however would prevent the name
from being available in the body of the match arm. Consider the following:
```
match Some("hi".to_string()) {
Some(s) if s.len() == 0 => // use s.
...
}
```
The variable `s` has type String, and its use in the guard is as a variable of
type String. The guard code effectively executes in a separate scope to the body
Expand All @@ -102,11 +106,13 @@ become unavailable in the body of the arm. Although this example seems
innocuous, the problem is most clear when considering functions that take their
argument by value.
```
match Some("hi".to_string()) {
Some(s) if { drop(s); false } => (),
Some(s) => // use s.
...
}
```
The value would be dropped in the guard then become unavailable not only in the
body of that arm but also in all subsequent arms! The solution is to bind by
Expand Down Expand Up @@ -218,6 +224,7 @@ An if-let pattern attempts to match the pattern, and enters the body if the
match was succesful. If the match is irrefutable (when it cannot fail to match),
use a regular `let`-binding instead. For instance:
```
struct Irrefutable(i32);
let irr = Irrefutable(0);
Expand All @@ -230,13 +237,15 @@ if let Irrefutable(x) = irr {
// Try this instead:
let Irrefutable(x) = irr;
foo(x);
```
"##,

E0165: r##"
A while-let pattern attempts to match the pattern, and enters the body if the
match was succesful. If the match is irrefutable (when it cannot fail to match),
use a regular `let`-binding inside a `loop` instead. For instance:
```
struct Irrefutable(i32);
let irr = Irrefutable(0);
Expand All @@ -250,6 +259,7 @@ loop {
let Irrefutable(x) = irr;
...
}
```
"##,

E0170: r##"
Expand Down Expand Up @@ -304,6 +314,7 @@ that a name will be extracted in all cases. Instead of pattern matching the
loop variable, consider using a `match` or `if let` inside the loop body. For
instance:
```
// This fails because `None` is not covered.
for Some(x) in xs {
...
Expand All @@ -323,6 +334,7 @@ for item in xs {
...
}
}
```
"##,

E0301: r##"
Expand All @@ -332,11 +344,13 @@ on which the match depends in such a way, that the match would not be
exhaustive. For instance, the following would not match any arm if mutable
borrows were allowed:
```
match Some(()) {
None => { },
option if option.take().is_none() => { /* impossible, option is `Some` */ },
Some(_) => { } // When the previous match failed, the option became `None`.
}
```
"##,

E0302: r##"
Expand All @@ -346,21 +360,24 @@ on which the match depends in such a way, that the match would not be
exhaustive. For instance, the following would not match any arm if assignments
were allowed:
```
match Some(()) {
None => { },
option if { option = None; false } { },
Some(_) => { } // When the previous match failed, the option became `None`.
}
```
"##,

E0303: r##"
In certain cases it is possible for sub-bindings to violate memory safety.
Updates to the borrow checker in a future version of Rust may remove this
restriction, but for now patterns must be rewritten without sub-bindings.
// Before.
match Some("hi".to_string()) {
ref op_string_ref @ Some(ref s) => ...
```
// Code like this...
match Some(5) {
ref op_num @ Some(num) => ...
None => ...
}
Expand All @@ -372,6 +389,7 @@ match Some("hi".to_string()) {
}
None => ...
}
```
The `op_string_ref` binding has type &Option<&String> in both cases.
Expand Down

0 comments on commit 1d7d019

Please sign in to comment.