delete more useless pub

rust-lang · Oct 13, 2023 · 1703f14 · 1703f14
1 parent fdaff05
commit 1703f14
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 14 deletions.
diff --git a/library/core/tests/lib.rs b/library/core/tests/lib.rs
@@ -121,8 +121,6 @@
 #![deny(unsafe_op_in_unsafe_fn)]
 #![deny(fuzzy_provenance_casts)]
 
-extern crate test;
-
 mod alloc;
 mod any;
 mod array;

diff --git a/library/core/tests/num/flt2dec/mod.rs b/library/core/tests/num/flt2dec/mod.rs
@@ -8,8 +8,6 @@ use core::num::flt2dec::{
 };
 use core::num::fmt::{Formatted, Part};
 
-pub use test::Bencher;
-
 mod estimator;
 mod strategy {
     mod dragon;

diff --git a/library/std/src/sys/common/mod.rs b/library/std/src/sys/common/mod.rs
@@ -9,6 +9,7 @@
 // Progress on this is tracked in #84187.
 
 #![allow(dead_code)]
+#![allow(unused_imports)]
 
 pub mod alloc;
 pub mod small_c_string;

diff --git a/src/tools/clippy/tests/ui/enum_glob_use.fixed b/src/tools/clippy/tests/ui/enum_glob_use.fixed
@@ -19,7 +19,7 @@ mod in_fn_test {
 }
 
 mod blurg {
-    pub use std::cmp::Ordering::*; // ok, re-export
+     // ok, re-export
 }
 
 fn main() {

diff --git a/src/tools/clippy/tests/ui/enum_glob_use.stderr b/src/tools/clippy/tests/ui/enum_glob_use.stderr
@@ -1,3 +1,12 @@
+error: unused import: `std::cmp::Ordering::*`
+  --> $DIR/enum_glob_use.rs:22:13
+   |
+LL |     pub use std::cmp::Ordering::*; // ok, re-export
+   |             ^^^^^^^^^^^^^^^^^^^^^
+   |
+   = note: `-D unused-imports` implied by `-D warnings`
+   = help: to override `-D warnings` add `#[allow(unused_imports)]`
+
 error: usage of wildcard import for enum variants
   --> $DIR/enum_glob_use.rs:5:5
    |
@@ -19,5 +28,5 @@ error: usage of wildcard import for enum variants
 LL |         use crate::Enum::*;
    |             ^^^^^^^^^^^^^^ help: try: `crate::Enum::Foo`
 
-error: aborting due to 3 previous errors
+error: aborting due to 4 previous errors
 
diff --git a/src/tools/miri/tests/utils/mod.rs b/src/tools/miri/tests/utils/mod.rs
@@ -1,4 +1,5 @@
 #![allow(dead_code)]
+#![allow(unused_imports)]
 
 #[macro_use]
 mod macros;

diff --git a/src/tools/rust-analyzer/crates/syntax/src/tests/sourcegen_ast.rs b/src/tools/rust-analyzer/crates/syntax/src/tests/sourcegen_ast.rs
@@ -450,7 +450,6 @@ fn generate_syntax_kinds(grammar: KindsSrc<'_>) -> String {
             [ident] => { $crate::SyntaxKind::IDENT };
             [shebang] => { $crate::SyntaxKind::SHEBANG };
         }
-        pub use T;
     };
 
     sourcegen::add_preamble("sourcegen_ast", sourcegen::reformat(ast.to_string()))

diff --git a/src/tools/rustfmt/src/config/options.rs b/src/tools/rustfmt/src/config/options.rs
@@ -142,13 +142,6 @@ pub enum HexLiteralCase {
     Lower,
 }
 
-#[config_type]
-pub enum ReportTactic {
-    Always,
-    Unnumbered,
-    Never,
-}
-
 /// What Rustfmt should emit. Mostly corresponds to the `--emit` command line
 /// option.
 #[config_type]