Implement caching via tasks instead of shared mutexes #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream issue: teamcapybara/capybara#2779
Tools like rustfmt and rust-analyzer don't like a lot of stuff in the body of a macro, so we use the macro just to construct an ad-hoc enum of the choices and leave most code outside.
This helps prevent a rare suboptimal case where a visitor to the playground triggered the crates / versions request but then left the site before the request finished, resulting in the request being canceled and the work being wasted without being cached. This mostly showed up when running heavy load tests locally to try and suss out other bugs. Other benefits: - This will also result in reduced contention when multiple requests would have triggered a cache refresh. Only one computation should occur. - The cache value is now computed out-of-band and requests should not block on it.
shepmaster
force-pushed
the
cache-rework
branch
from
843cacb to
f116c28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps prevent a rare suboptimal case where a visitor to the
playground triggered the crates / versions request but then left the
site before the request finished, resulting in the request being
canceled and the work being wasted without being cached. This mostly
showed up when running heavy load tests locally to try and suss out
other bugs.
Other benefits:
This will also result in reduced contention when multiple requests
would have triggered a cache refresh. Only one computation should
occur.
The cache value is now computed out-of-band and requests should not
block on it.