-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout for running, building, linting any code #469
Comments
Unsure of the root cause, although rust-lang/cargo#6720 looks like a likely candidate. |
Yea, I think I have a fix. Testing with docker is a little slow. |
That can be an understatement. I tend to do some heavy editing of https://github.com/integer32llc/rust-playground/blob/master/compiler/base/Cargo.toml to reduce the number of crates that are required. It also looks like the intra-stage caching is broken again, at least on Travis, so that's probably not helping either. |
Fingerprint build script deps only for path packages. #6720 introduced some protection that if there is a build script, and two commands are used (such as `cargo build` then `cargo test`), the second command would correctly get rebuilt. However, the way it was implemented relies on mtimes working correctly. A common use case is to cache built dependencies in Docker, and Docker zeros the nanoseconds from mtime when the image is saved. This caused all packages that had build scripts to get rebuilt when the Docker image runs. The solution here is to only use the #6720 protection for local (path) packages. This runs under the assumption that mtimes need to work for those anyways. The consequence is that the scenario in #6720 will no longer work for detecting changes in registry dependencies with build scripts. Fixing that final edge case is nontrivial. Since it is unlikely to happen often, I figure this workaround should be sufficient for now. cc rust-lang/rust-playground#469 cc rust-lang/rust#59061
I see #6734 has been merged, but the nightly playground is still timing out. |
There are multiple steps:
|
Thank you, @ehuss! |
Eg:
The text was updated successfully, but these errors were encountered: